Skip to content

Commit 287d7ea

Browse files
authored
Add comment to gRPC template tests SkipOnAlpine attribute (#46517)
1 parent 9a6883f commit 287d7ea

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/ProjectTemplates/test/Templates.Tests/GrpcTemplateTest.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -36,31 +36,31 @@ public ITestOutputHelper Output
3636

3737
[ConditionalFact]
3838
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
39-
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
39+
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
4040
public async Task GrpcTemplate()
4141
{
4242
await GrpcTemplateCore();
4343
}
4444

4545
[ConditionalFact(Skip = "Unskip when there are no more build or publish warnings for native AOT.")]
4646
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
47-
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
47+
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
4848
public async Task GrpcTemplateNativeAot()
4949
{
5050
await GrpcTemplateCore(args: new[] { ArgConstants.PublishNativeAot });
5151
}
5252

5353
[ConditionalFact]
5454
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
55-
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
55+
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
5656
public async Task GrpcTemplateProgramMain()
5757
{
5858
await GrpcTemplateCore(args: new[] { ArgConstants.UseProgramMain });
5959
}
6060

6161
[ConditionalFact(Skip = "Unskip when there are no more build or publish warnings for native AOT.")]
6262
[SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
63-
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")]
63+
[SkipOnAlpine("https://github.com/grpc/grpc/issues/18338")] // protoc doesn't support Alpine. Note that the issue was closed with a workaround which isn't applied to our OS image.
6464
public async Task GrpcTemplateProgramMainNativeAot()
6565
{
6666
await GrpcTemplateCore(args: new[] { ArgConstants.UseProgramMain, ArgConstants.PublishNativeAot });

0 commit comments

Comments
 (0)