Skip to content

Commit 416c78b

Browse files
authored
Build native assets just once per job on CI (#22909)
- at best, was a performance drain - at worst, broke builds entirely
1 parent b284229 commit 416c78b

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.azure/pipelines/ci.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ stages:
186186
-noBuildRepoTasks
187187
-sign
188188
-buildInstallers
189+
-noBuildNative
189190
/p:DotNetSignType=$(_SignType)
190191
/p:AssetManifestFileName=aspnetcore-win-x64-x86.xml
191192
$(_BuildArgs)
@@ -529,7 +530,7 @@ stages:
529530
steps:
530531
- script: ./build.cmd -ci -nobl -all -pack $(_InternalRuntimeDownloadArgs)
531532
displayName: Build Repo
532-
- script: ./src/ProjectTemplates/build.cmd -ci -nobl -noBuildRepoTasks -pack -NoRestore -NoBuilddeps "/p:RunTemplateTests=true"
533+
- script: ./src/ProjectTemplates/build.cmd -ci -nobl -noBuildRepoTasks -pack -NoRestore -noBuildNative -NoBuilddeps "/p:RunTemplateTests=true"
533534
displayName: Pack Templates
534535
- script: ./src/ProjectTemplates/build.cmd -ci -nobl -noBuildRepoTasks -test -NoRestore -NoBuild -NoBuilddeps "/p:RunTemplateTests=true"
535536
displayName: Test Templates
@@ -603,7 +604,7 @@ stages:
603604
# Build the shared framework
604605
- script: ./build.cmd -ci -nobl -all -pack -arch x64 /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
605606
displayName: Build shared fx
606-
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -projects src/Grpc/**/*.csproj
607+
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -noBuildNative -projects src/Grpc/**/*.csproj
607608
displayName: Restore interop projects
608609
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildNative -projects eng\helix\helix.proj
609610
/p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true

.azure/pipelines/helix-matrix.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
# Build the shared framework
2929
- script: ./build.cmd -ci -nobl -all -pack -arch x64 /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
3030
displayName: Build shared fx
31-
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -projects src/Grpc/**/*.csproj
31+
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -noBuildNative -projects src/Grpc/**/*.csproj
3232
displayName: Restore interop projects
3333
- script: .\build.cmd -ci -nobl -noBuildRepoTasks -NoRestore -test -all -noBuildNative -projects eng\helix\helix.proj
3434
/p:IsHelixDaily=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true

.azure/pipelines/quarantined-tests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
# Build the shared framework
3434
- script: ./build.cmd -ci -nobl -all -pack -arch x64 /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
3535
displayName: Build shared fx
36-
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -projects src/Grpc/**/*.csproj
36+
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -restore -noBuild -noBuildNative -projects src/Grpc/**/*.csproj
3737
displayName: Restore interop projects
3838
- script: ./build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildJava -noBuildNative
3939
-projects eng\helix\helix.proj /p:RunQuarantinedTests=true /p:IsRequiredCheck=true /p:IsHelixJob=true
@@ -146,4 +146,4 @@ jobs:
146146
- name: Linux_Quarantined_Test_Results
147147
path: artifacts/TestResults/
148148
publishOnError: true
149-
includeForks: true
149+
includeForks: true

0 commit comments

Comments
 (0)