Skip to content

Commit 213d48f

Browse files
authored
Query: Remove redundant override of TranslateSubquery (#25637)
Added override to do custom task for GroupBy which ended up getting removed in final implementation but method was left behind Part of #24743
1 parent 139eb9d commit 213d48f

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs

-15
Original file line numberDiff line numberDiff line change
@@ -158,21 +158,6 @@ when queryRootExpression.EntityType.GetSqlQueryMappings().FirstOrDefault(m => m.
158158
}
159159
}
160160

161-
/// <inheritdoc />
162-
public override ShapedQueryExpression? TranslateSubquery(Expression expression)
163-
{
164-
Check.NotNull(expression, nameof(expression));
165-
166-
var subqueryVisitor = (RelationalQueryableMethodTranslatingExpressionVisitor)CreateSubqueryVisitor();
167-
var translation = subqueryVisitor.Visit(expression) as ShapedQueryExpression;
168-
if (translation == null && subqueryVisitor.TranslationErrorDetails != null)
169-
{
170-
AddTranslationErrorDetails(subqueryVisitor.TranslationErrorDetails);
171-
}
172-
173-
return translation;
174-
}
175-
176161
/// <inheritdoc />
177162
protected override QueryableMethodTranslatingExpressionVisitor CreateSubqueryVisitor()
178163
=> new RelationalQueryableMethodTranslatingExpressionVisitor(this);

0 commit comments

Comments
 (0)