Skip to content

Commit a5ed891

Browse files
committed
[Java.Interop.Tools.Cecil] Fix the xamarin-android build
Context: dotnet/android#5945 Context: https://github.com/xamarin/xamarin-android/blob/d5ef9982dc7b9efc22f7efb80ed0b58ff0bd7cdb/src/Microsoft.Android.Sdk.ILLink/Microsoft.Android.Sdk.ILLink.csproj#L43-L46 Xamarin.Android's `Microsoft.Android.Sdk.ILLink.dll` assembly uses `TypeDefinitionCache`, but doesn't reference the `Java.Interop.Tools.Cecil.dll` assembly. Instead, it references some of the sources in `src/Java.Interop.Tools.Cecil`, and *no* sources for any of `Java.Interop.Tools.Cecil.dll`s dependencies, such as `Java.Interop.Tools.Diagnostics.dll`. This meant that while commit 2573dc8 built for Java.Interop, it broke the xamarin-android build, by introducing an (unnecessary) `using Java.Interop.Tools.Diagnostics` into `TypeDefinitionCache.cs`: …/TypeDefinitionCache.cs(4,26): error CS0234: The type or namespace name 'Diagnostics' does not exist in the namespace 'Java.Interop.Tools' (are you missing an assembly reference?) […/xamarin-android/src/Microsoft.Android.Sdk.ILLink/Microsoft.Android.Sdk.ILLink.csproj] The `using Java.Interop.Tools.Diagnostics` wasn't actually needed; it was part of an unnecessary tangent. Remove the `using Java.Interop.Tools.Diagnostics` statement, allowing the xamarin-android build to progress.
1 parent 2573dc8 commit a5ed891

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/Java.Interop.Tools.Cecil/Java.Interop.Tools.Cecil/TypeDefinitionCache.cs

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
using System.Collections.Generic;
22
using Mono.Cecil;
33

4-
using Java.Interop.Tools.Diagnostics;
5-
64
namespace Java.Interop.Tools.Cecil
75
{
86
/// <summary>

0 commit comments

Comments
 (0)