Skip to content

Commit 30df61a

Browse files
authored
Internalization of OneToOne and ManyToOne Column classes (#2632)
* Internalization of OneToOne and ManyToOne Column classes * PR feedback.
1 parent 4d4cfbb commit 30df61a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/Microsoft.ML.Data/Transforms/ColumnBindingsBase.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
namespace Microsoft.ML.Data
1616
{
17-
public abstract class SourceNameColumnBase
17+
internal abstract class SourceNameColumnBase
1818
{
1919
[Argument(ArgumentType.AtMostOnce, HelpText = "Name of the new column", ShortName = "name")]
2020
public string Name;
@@ -103,13 +103,15 @@ public bool TrySanitize()
103103
}
104104
}
105105

106-
public abstract class OneToOneColumn : SourceNameColumnBase
106+
[BestFriend]
107+
internal abstract class OneToOneColumn : SourceNameColumnBase
107108
{
108109
[BestFriend]
109110
private protected OneToOneColumn() { }
110111
}
111112

112-
public abstract class ManyToOneColumn
113+
[BestFriend]
114+
internal abstract class ManyToOneColumn
113115
{
114116
[Argument(ArgumentType.AtMostOnce, HelpText = "Name of the new column", ShortName = "name")]
115117
public string Name;

src/Microsoft.ML.Transforms/Text/WordHashBagProducingTransform.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ internal static IDataTransform Create(IHostEnvironment env, Options options, IDa
161161
/// </summary>
162162
internal static class NgramHashExtractingTransformer
163163
{
164-
public abstract class ColumnBase : ManyToOneColumn
164+
internal abstract class ColumnBase : ManyToOneColumn
165165
{
166166
[Argument(ArgumentType.AtMostOnce, HelpText = "Ngram length (stores all lengths up to the specified Ngram length)", ShortName = "ngram")]
167167
public int? NgramLength;

0 commit comments

Comments
 (0)