Senja comments

Author: TomFinley

src/Microsoft.ML.Api/TypedCursor.cs

@@ -563,8 +563,8 @@ public static ICursorable<TRow> AsCursorable<TRow>(this IDataView data, bool ign
             SchemaDefinition schemaDefinition = null)
             where TRow : class, new()
         {
-            // REVIEW: Take this as a parameter, or else make it a method on he context itself.
-            var ml = new MLContext(42);
+            // REVIEW: Take this as a parameter, or else make it a method on the context itself.
+            var ml = new MLContext();
             return data.AsCursorable<TRow>(ml, ignoreMissingColumns, schemaDefinition);
         }
 

src/Microsoft.ML.Core/Data/IHostEnvironment.cs

@@ -73,7 +73,7 @@ public interface IHostEnvironment : IChannelProvider, IProgressChannelProvider
         /// The use of suffix and prefix, including whether they have any affect, is up to the host environment.
         /// </summary>
         [Obsolete("The host environment is not disposable, so it is inappropriate to use this method. " +
-            "Handle your own temporary files. If you cannot, reconsider your life choices.")]
+            "Please handle your own temporary files within the component yourself, including their proper disposal and deletion.")]
         IFileHandle CreateTempFile(string suffix = null, string prefix = null);
 
         /// <summary>

src/Microsoft.ML.Core/Data/ServerChannel.cs

@@ -20,7 +20,7 @@ namespace Microsoft.ML.Runtime
     /// that the library will publish some sort of restful API.
     /// </summary>
     [BestFriend]
-    public sealed class ServerChannel : ServerChannel.IPendingBundleNotification, IDisposable
+    internal sealed class ServerChannel : ServerChannel.IPendingBundleNotification, IDisposable
     {
         // See ServerChannel.md for a more elaborate discussion of high level usage and design.
         private readonly IChannelProvider _chp;

src/Microsoft.ML.Data/Commands/DataCommand.cs

@@ -17,7 +17,8 @@ namespace Microsoft.ML.Runtime.Data
     /// <summary>
     /// This holds useful base classes for commands that ingest a primary dataset and deal with associated model files.
     /// </summary>
-    public static class DataCommand
+    [BestFriend]
+    internal static class DataCommand
     {
         public abstract class ArgumentsBase
         {