Skip to content

Make ConsoleEnvironment internal #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eerhardt opened this issue Oct 17, 2018 · 1 comment · Fixed by #1626
Closed

Make ConsoleEnvironment internal #1284

eerhardt opened this issue Oct 17, 2018 · 1 comment · Fixed by #1626
Labels
API Issues pertaining the friendly API enhancement New feature or request

Comments

@eerhardt
Copy link
Member

We don't expect external users to use the ConsoleEnvironment class. It should only be used for the command line tool.

We should make this class internal so it isn't part of our public API. That way we don't need to support it as a public API forever.

See #1252 (comment)

/cc @Zruty0 @TomFinley
@eerhardt eerhardt mentioned this issue Oct 17, 2018
Merged
@Zruty0
Copy link
Contributor

Zruty0 commented Oct 17, 2018

I agree.

@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Oct 19, 2018
@GalOshri GalOshri added the enhancement New feature or request label Oct 25, 2018
@YevhenLukomskyi YevhenLukomskyi mentioned this issue Oct 27, 2018
Closed
@eerhardt eerhardt mentioned this issue Nov 16, 2018
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API Issues pertaining the friendly API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Movement and Internalization Phase 2 TomFinley/machinelearning
4 participants
@Ivanidzo4ka @GalOshri @eerhardt @Zruty0