Remove TextLoader.Read(string), promote IDataReader<MSS> extension #1797
Labels
API
Issues pertaining the friendly API
good first issue
Good for newcomers
up-for-grabs
A good issue to fix if you are trying to contribute to the project
Pursuant to #1090 and #1041 there was agreement that we should be able to just pass a string into a data reader that reads from streams, rather than have to muck about with the creation of this
IMultiStreamSource
object.As it happens, this one request was done in two separate ways:
TextLoader
was created:machinelearning/src/Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs
Line 1340 in cb37c7e
IDataReader<IMultiStreamSource>
was introduced.Clearly we don't need both, and the second being more flexible and more broadly applicable was the one that should be checked in, so let us remove the class specific method introduced in #1252. The extension method should however be moved to a namespace where it is more likely to be picked up (probably
Microsoft.ML
) since right now it's a bit buried and generally people would never see this extension method.The text was updated successfully, but these errors were encountered: