Move various bits of code to the after package load code in RoslynPackage (#77745)

1) Move the *very expensive* color schema applier initialization code to occur after package load. I talked with Joey about this and he indicated this could (quite infrequently) cause a recolorization in the editor upon open, but only when the user had previously changed themes or the very first open of a C# file after install.

2) Move the global notification service construction to happen on a bg thread, bright before it's use.

3) Move the SolutionEventMonitor construction and bulk file notification registration to occur after solution load. The bulk notification for the solution open would have already been initiated if the package load occurs during solution load, so this shouldn't affect that notification.

4) A bit of cleanup from earlier PRs: (VB lambda param cleanup, removing duplicated MiscellaneousFilesWorkspace service retrieval)

Author: ToddGrun

src/VisualStudio/Core/Def/ColorSchemes/ColorSchemeApplier.cs

@@ -67,10 +67,10 @@ public void RegisterInitializationWork(PackageLoadTasks packageInitializationTas
             _isInitialized = true;
         }
 
-        packageInitializationTasks.AddTask(isMainThreadTask: false, task: PackageInitializationBackgroundThreadAsync);
+        packageInitializationTasks.AddTask(isMainThreadTask: false, task: AfterPackageLoadedBackgroundThreadAsync);
     }
 
-    private async Task PackageInitializationBackgroundThreadAsync(PackageLoadTasks packageInitializationTasks, CancellationToken cancellationToken)
+    private async Task AfterPackageLoadedBackgroundThreadAsync(PackageLoadTasks afterPackageLoadedTasks, CancellationToken cancellationToken)
     {
         var settingsManager = await _asyncServiceProvider.GetServiceAsync<SVsSettingsPersistenceManager, ISettingsManager>(_threadingContext.JoinableTaskFactory).ConfigureAwait(false);
 

src/VisualStudio/Core/Def/LanguageService/AbstractPackage`2.cs

@@ -58,6 +58,9 @@ private async Task PackageInitializationMainThreadAsync(PackageLoadTasks package
             RegisterEditorFactory(editorFactory);
         }
 
+        // Misc workspace has to be up and running by the time our package is usable so that it can track running
+        // doc events and appropriately map files to/from it and other relevant workspaces (like the
+        // metadata-as-source workspace).
         var miscellaneousFilesWorkspace = this.ComponentModel.GetService<MiscellaneousFilesWorkspace>();
 
         // awaiting an IVsTask guarantees to return on the captured context

src/VisualStudio/Core/Def/RoslynPackage.cs

@@ -5,7 +5,6 @@
 using System;
 using System.Collections.Immutable;
 using System.ComponentModel.Design;
-using System.IO;
 using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
@@ -20,7 +19,6 @@
 using Microsoft.CodeAnalysis.Options;
 using Microsoft.CodeAnalysis.Remote.ProjectSystem;
 using Microsoft.CodeAnalysis.Shared.TestHooks;
-using Microsoft.CodeAnalysis.SolutionCrawler;
 using Microsoft.VisualStudio.ComponentModelHost;
 using Microsoft.VisualStudio.LanguageServices.EditorConfigSettings;
 using Microsoft.VisualStudio.LanguageServices.Implementation.Diagnostics;
@@ -32,7 +30,6 @@
 using Microsoft.VisualStudio.LanguageServices.Implementation.TableDataSource;
 using Microsoft.VisualStudio.LanguageServices.Implementation.UnusedReferences;
 using Microsoft.VisualStudio.LanguageServices.InheritanceMargin;
-using Microsoft.VisualStudio.LanguageServices.Options;
 using Microsoft.VisualStudio.LanguageServices.ProjectSystem;
 using Microsoft.VisualStudio.LanguageServices.ProjectSystem.BrokeredService;
 using Microsoft.VisualStudio.LanguageServices.StackTraceExplorer;
@@ -54,7 +51,6 @@ internal sealed class RoslynPackage : AbstractPackage
     private static RoslynPackage? s_lazyInstance;
 
     private RuleSetEventHandler? _ruleSetEventHandler;
-    private ColorSchemeApplier? _colorSchemeApplier;
     private SolutionEventMonitor? _solutionEventMonitor;
 
     internal static async ValueTask<RoslynPackage?> GetOrLoadAsync(IThreadingContext threadingContext, IAsyncServiceProvider serviceProvider, CancellationToken cancellationToken)
@@ -85,13 +81,6 @@ protected override void RegisterInitializeAsyncWork(PackageLoadTasks packageInit
 
     private async Task PackageInitializationBackgroundThreadAsync(PackageLoadTasks packageInitializationTasks, CancellationToken cancellationToken)
     {
-        _colorSchemeApplier = ComponentModel.GetService<ColorSchemeApplier>();
-        _colorSchemeApplier.RegisterInitializationWork(packageInitializationTasks);
-
-        // We are at the VS layer, so we know we must be able to get the IGlobalOperationNotificationService here.
-        var globalNotificationService = this.ComponentModel.GetService<IGlobalOperationNotificationService>();
-        Assumes.Present(globalNotificationService);
-
         await ProfferServiceBrokerServicesAsync().ConfigureAwait(true);
 
         var settingsEditorFactory = this.ComponentModel.GetService<SettingsEditorFactory>();
@@ -100,16 +89,8 @@ private async Task PackageInitializationBackgroundThreadAsync(PackageLoadTasks p
             isMainThreadTask: true,
             task: (packageInitializationTasks, cancellationToken) =>
             {
-                _solutionEventMonitor = new SolutionEventMonitor(globalNotificationService);
-                TrackBulkFileOperations(globalNotificationService);
-
                 RegisterEditorFactory(settingsEditorFactory);
 
-                // Misc workspace has to be up and running by the time our package is usable so that it can track running
-                // doc events and appropriately map files to/from it and other relevant workspaces (like the
-                // metadata-as-source workspace).
-                var miscellaneousFilesWorkspace = this.ComponentModel.GetService<MiscellaneousFilesWorkspace>();
-
                 return Task.CompletedTask;
             });
     }
@@ -125,6 +106,16 @@ protected override void RegisterOnAfterPackageLoadedAsyncWork(PackageLoadTasks a
 
         Task OnAfterPackageLoadedBackgroundThreadAsync(PackageLoadTasks afterPackageLoadedTasks, CancellationToken cancellationToken)
         {
+            var colorSchemeApplier = ComponentModel.GetService<ColorSchemeApplier>();
+            colorSchemeApplier.RegisterInitializationWork(afterPackageLoadedTasks);
+
+            // We are at the VS layer, so we know we must be able to get the IGlobalOperationNotificationService here.
+            var globalNotificationService = this.ComponentModel.GetService<IGlobalOperationNotificationService>();
+            Assumes.Present(globalNotificationService);
+
+            _solutionEventMonitor = new SolutionEventMonitor(globalNotificationService);
+            TrackBulkFileOperations(globalNotificationService);
+
             // Ensure the options persisters are loaded since we have to fetch options from the shell
             LoadOptionPersistersAsync(this.ComponentModel, cancellationToken).Forget();
 

src/VisualStudio/VisualBasic/Impl/LanguageService/VisualBasicPackage.vb

@@ -69,7 +69,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.VisualBasic
 
             packageInitializationTasks.AddTask(
                 isMainThreadTask:=False,
-                task:=Function(packageInitializationTasks2, cancellationToken) As Task
+                task:=Function() As Task
                           Try
                               RegisterLanguageService(GetType(IVbCompilerService), Function() Task.FromResult(_comAggregate))