Fix invalid parameters in SetFileInformationByHandle (#95235)

* Add failing unit test for SetFileInformationByHandle (#95096)

* Fix invalid parameters in SetFileInformationByHandle (#95096)

According to MS-FSCC, "a value of -1 indicates to the server that it MUST NOT change this attribute for all subsequent operations"
This behavior is incorrect in the scope of .NET, since a call to File.SetLastAccessTime on a open file handle
will cause all future writes to not update the last write tim.

It also triggers STATUS_INVALID_PARAMETER on NFS, since the Windows driver doesn't seem to implement the -1 value (tracking of subsequent write operations)

Fixes #95096

Author: smx-smx

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs

@@ -464,10 +464,10 @@ public static unsafe void SetAttributes(SafeFileHandle fileHandle, FileAttribute
         private static void SetFileTime(
             string fullPath,
             bool asDirectory,
-            long creationTime = -1,
-            long lastAccessTime = -1,
-            long lastWriteTime = -1,
-            long changeTime = -1,
+            long creationTime = 0,
+            long lastAccessTime = 0,
+            long lastWriteTime = 0,
+            long changeTime = 0,
             uint fileAttributes = 0)
         {
             using SafeFileHandle handle = OpenHandleToWriteAttributes(fullPath, asDirectory);
@@ -477,10 +477,10 @@ private static void SetFileTime(
         private static unsafe void SetFileTime(
             SafeFileHandle fileHandle,
             string? fullPath = null,
-            long creationTime = -1,
-            long lastAccessTime = -1,
-            long lastWriteTime = -1,
-            long changeTime = -1,
+            long creationTime = 0,
+            long lastAccessTime = 0,
+            long lastWriteTime = 0,
+            long changeTime = 0,
             uint fileAttributes = 0)
         {
             var basicInfo = new Interop.Kernel32.FILE_BASIC_INFO

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/File/GetSetTimes_SafeFileHandle.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Threading.Tasks;
 using Microsoft.Win32.SafeHandles;
 using Xunit;
 
@@ -91,15 +92,34 @@ protected override DateTime GetLastWriteTimeUtc(string path)
             return File.GetLastWriteTimeUtc(fileHandle);
         }
 
+        [Fact]
+        public async Task WritingShouldUpdateWriteTime_After_SetLastAccessTime()
+        {
+            string filePath = GetTestFilePath();
+            using var handle = OpenFileHandle(filePath, FileAccess.ReadWrite);
+
+            File.SetLastAccessTime(handle, DateTime.Now.Subtract(TimeSpan.FromDays(1)));
+            var timeBeforeWrite = File.GetLastWriteTime(handle);
+
+            using var writer = new StreamWriter(new FileStream(handle, FileAccess.ReadWrite));
+            writer.AutoFlush = true;
+            writer.WriteLine("now: " + DateTime.Now);
+            await Task.Delay(2000);
+            writer.WriteLine("now: " + DateTime.Now);
+
+            var timeAfterWrite = File.GetLastWriteTime(handle);
+            Assert.True(timeAfterWrite > timeBeforeWrite);
+        }
+
         [Fact]
         public void NullArgumentValidation()
         {
             Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetCreationTime(default(SafeFileHandle)!));
             Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetCreationTime(default(SafeFileHandle)!, DateTime.Now));
-            
+
             Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetCreationTimeUtc(default(SafeFileHandle)!));
             Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetCreationTimeUtc(default(SafeFileHandle)!, DateTime.Now));
-            
+
             Assert.Throws<ArgumentNullException>("fileHandle", static () => File.GetLastAccessTime(default(SafeFileHandle)!));
             Assert.Throws<ArgumentNullException>("fileHandle", static () => File.SetLastAccessTime(default(SafeFileHandle)!, DateTime.Now));