Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Server 2025 to test configurations #111938

Merged
merged 7 commits into from
Feb 4, 2025
Merged

Conversation

artl93
Copy link
Member

@artl93 artl93 commented Jan 29, 2025

Adding runs for Windows Server 2025.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@artl93
Copy link
Member Author

artl93 commented Jan 29, 2025

@dotnet-bot help

@artl93 artl93 changed the title (WIP) Add Windows Server 2025 test runs Add Windows Server 2025 to test configurations Jan 29, 2025
@artl93
Copy link
Member Author

artl93 commented Jan 29, 2025

@dotnet-bot test outerloop

@ericstj
Copy link
Member

ericstj commented Jan 29, 2025

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ericstj
Copy link
Member

ericstj commented Jan 29, 2025

/azp run runtime-libraries-coreclr outerloop-windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ericstj
Copy link
Member

ericstj commented Jan 30, 2025

/azp run runtime-libraries-coreclr outerloop-windows

@ericstj
Copy link
Member

ericstj commented Jan 30, 2025

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Simplify selecting server.

Co-authored-by: Eric StJohn <[email protected]>
@artl93
Copy link
Member Author

artl93 commented Jan 30, 2025

@lewing, @radekdoulik and @mthalman - I opened #112009 to track adding images for this. Please advice if we should hold this PR for that change.

@artl93
Copy link
Member Author

artl93 commented Jan 30, 2025

/azp run runtime-libraries-coreclr outerloop-windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@artl93
Copy link
Member Author

artl93 commented Jan 30, 2025

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@artl93 artl93 closed this Jan 30, 2025
@artl93 artl93 reopened this Jan 30, 2025
@artl93
Copy link
Member Author

artl93 commented Jan 30, 2025

/azp run runtime-extra-platforms

@artl93
Copy link
Member Author

artl93 commented Jan 30, 2025

/azp run runtime-libraries-coreclr outerloop-windows

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just recently removed a queue (Windows 8.1) so I'm fine with this from a resource perspective.

@lewing
Copy link
Member

lewing commented Feb 4, 2025

/ba-g timeout is known

@lewing lewing merged commit 2c77535 into dotnet:main Feb 4, 2025
85 of 87 checks passed
@artl93 artl93 deleted the artl/svr2025 branch February 4, 2025 06:35
grendello added a commit to grendello/runtime that referenced this pull request Feb 4, 2025
* main: (30 commits)
  JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979)
  Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927)
  Add Windows Server 2025 to test configurations (dotnet#111938)
  [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454)
  arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893)
  JIT: Fix cross crossgen comparison failures (dotnet#112078)
  Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278)
  Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098)
  Use hardlinks in helixpublishwitharcade (dotnet#112091)
  Update breaking change rules regarding byref/objref fields. (dotnet#112087)
  [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076)
  use collection syntax in illink (dotnet#108458)
  Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879)
  [main] Update dependencies from dotnet/emsdk (dotnet#111690)
  Enable Mono tests (dotnet#111981)
  Let the debugger knows DATAS is on (dotnet#107115)
  Tests ran counter (dotnet#111145)
  Some System.Decimal performance improvements (dotnet#99212)
  [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886)
  Remove one usage of `Unsafe.AsPointer`. (dotnet#112079)
  ...
@artl93
Copy link
Member Author

artl93 commented Feb 5, 2025

/backport to release/8.0-staging

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13164748701

Copy link
Contributor

github-actions bot commented Feb 5, 2025

@artl93 backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: (WIP) Add Windows Server 2025 test runs
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/helix-queues-setup.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/helix-queues-setup.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/helix-queues-setup.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 (WIP) Add Windows Server 2025 test runs
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants