Dump collection on runtime test timeouts does not work anymore

[SingleAccretion]

Sample log:

Invoking: C:\h\w\B0990A36\p\createdump.exe --name "C:\cores\crashdump_4900.dmp" 4900 --withheap
createdump stdout:

createdump stderr:
[createdump] The pid argument is no longer supported

Failed to collect crash dump
    JIT\Regression\clr-x64-JIT\v4.0\devdiv374539\DevDiv_374539\DevDiv_374539.cmd [FAIL]

This is done by code here:

runtime/src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs

Lines 209 to 212 in 3454d8c

	string coreRoot = Environment.GetEnvironmentVariable("CORE_ROOT");
	string createdumpPath = Path.Combine(coreRoot, "createdump");
	string arguments = $"--name \"{path}\" {process.Id} --withheap";
	Process createdump = new Process();

Which evidently does not work anymore.

[ghost]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Sample log:

Invoking: C:\h\w\B0990A36\p\createdump.exe --name "C:\cores\crashdump_4900.dmp" 4900 --withheap
createdump stdout:

createdump stderr:
[createdump] The pid argument is no longer supported

Failed to collect crash dump
    JIT\Regression\clr-x64-JIT\v4.0\devdiv374539\DevDiv_374539\DevDiv_374539.cmd [FAIL]

This is done by code here:

runtime/src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs

Lines 209 to 212 in 3454d8c

	string coreRoot = Environment.GetEnvironmentVariable("CORE_ROOT");
	string createdumpPath = Path.Combine(coreRoot, "createdump");
	string arguments = $"--name \"{path}\" {process.Id} --withheap";
	Process createdump = new Process();

Which evidently does not work anymore.

Author:	SingleAccretion
Assignees:	-
Labels:	area-Infrastructure-coreclr
Milestone:	-

[jkotas]

The pid argument is no longer supported

Introduced by #68877 . cc @mikem8361

[dotnet-policy-service]

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

[mikem8361]

We changed createdump a long time ago (.NET 3.1 I think) to only dump it's parent process on Windows only for security reasons. Linux/MacOS still take a pid.