fixed CA2211 - Non-constant fields should not be visible

Author: vlada-shubina

.editorconfig

@@ -169,9 +169,6 @@ dotnet_diagnostic.CA2007.severity = warning
 # Do not raise reserved exception types
 dotnet_diagnostic.CA2201.severity = suggestion
 
-# Non-constant fields should not be visible
-dotnet_diagnostic.CA2211.severity = suggestion
-
 # Using directive is unnecessary
 dotnet_diagnostic.IDE0005.severity = warning
 

Microsoft.NET.Build.Containers/KnownStrings.cs

@@ -7,32 +7,32 @@ public static class KnownStrings
 {
     public static class Properties
     {
-        public static string ContainerBaseImage = nameof(ContainerBaseImage);
-        public static string ContainerRegistry = nameof(ContainerRegistry);
-        public static string ContainerImageName = nameof(ContainerImageName);
-        public static string ContainerImageTag = nameof(ContainerImageTag);
-        public static string ContainerImageTags = nameof(ContainerImageTags);
-        public static string ContainerWorkingDirectory = nameof(ContainerWorkingDirectory);
-        public static string ContainerEntrypoint = nameof(ContainerEntrypoint);
-        public static string UseAppHost = nameof(UseAppHost);
-        public static string ContainerLabel = nameof(ContainerLabel);
-        public static string SelfContained = nameof(SelfContained);
-        public static string ContainerPort = nameof(ContainerPort);
-        public static string ContainerEnvironmentVariable = nameof(ContainerEnvironmentVariable);
+        public static readonly string ContainerBaseImage = nameof(ContainerBaseImage);
+        public static readonly string ContainerRegistry = nameof(ContainerRegistry);
+        public static readonly string ContainerImageName = nameof(ContainerImageName);
+        public static readonly string ContainerImageTag = nameof(ContainerImageTag);
+        public static readonly string ContainerImageTags = nameof(ContainerImageTags);
+        public static readonly string ContainerWorkingDirectory = nameof(ContainerWorkingDirectory);
+        public static readonly string ContainerEntrypoint = nameof(ContainerEntrypoint);
+        public static readonly string UseAppHost = nameof(UseAppHost);
+        public static readonly string ContainerLabel = nameof(ContainerLabel);
+        public static readonly string SelfContained = nameof(SelfContained);
+        public static readonly string ContainerPort = nameof(ContainerPort);
+        public static readonly string ContainerEnvironmentVariable = nameof(ContainerEnvironmentVariable);
 
-        public static string ComputeContainerConfig = nameof(ComputeContainerConfig);
-        public static string AssemblyName = nameof(AssemblyName);
-        public static string ContainerBaseRegistry = nameof(ContainerBaseRegistry);
-        public static string ContainerBaseName = nameof(ContainerBaseName);
-        public static string ContainerBaseTag = nameof(ContainerBaseTag);
+        public static readonly string ComputeContainerConfig = nameof(ComputeContainerConfig);
+        public static readonly string AssemblyName = nameof(AssemblyName);
+        public static readonly string ContainerBaseRegistry = nameof(ContainerBaseRegistry);
+        public static readonly string ContainerBaseName = nameof(ContainerBaseName);
+        public static readonly string ContainerBaseTag = nameof(ContainerBaseTag);
 
-        public static string ContainerGenerateLabels = nameof(ContainerGenerateLabels);
+        public static readonly string ContainerGenerateLabels = nameof(ContainerGenerateLabels);
     }
 
     public static class ErrorCodes
     {
-        public static string CONTAINER001 = nameof(CONTAINER001);
-        public static string CONTAINER004 = nameof(CONTAINER004);
-        public static string CONTAINER005 = nameof(CONTAINER005);
+        public static readonly string CONTAINER001 = nameof(CONTAINER001);
+        public static readonly string CONTAINER004 = nameof(CONTAINER004);
+        public static readonly string CONTAINER005 = nameof(CONTAINER005);
     }
 }

Microsoft.NET.Build.Containers/ReferenceParser.cs

@@ -200,7 +200,7 @@ public static class ReferenceParser
     /// is anchored and has capturing groups for name, tag, and digest
     /// components.
     /// </summary>
-    public static Regex ReferenceRegexp = new(referencePat);
+    public static readonly Regex ReferenceRegexp = new(referencePat);
 
     /// <summary>
     /// identifier is the format for string identifier used as a