Skip to content

Poison infra is not scanning the SDK tarball #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NikolaMilosavljevic opened this issue Apr 15, 2025 · 0 comments · Fixed by dotnet/dotnet#230
Closed

Poison infra is not scanning the SDK tarball #5052

NikolaMilosavljevic opened this issue Apr 15, 2025 · 0 comments · Fixed by dotnet/dotnet#230
Assignees
@NikolaMilosavljevic
Labels
area-poison Poison leaks and the leak detection infrastructure

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Apr 15, 2025 •
edited
Loading

While investigating a poison issue I've noticed that AssetToCheck (https://github.com/dotnet/sdk/blob/5fcddd161b969f850684c2f9765acd4a129591a6/src/SourceBuild/content/eng/finish-source-only.proj#L132) item group does not include the sdk tarball.

ReportPoisonUsage target should depend on CopySdkArchive target.

Note that this will cause the build failure as new poisons will be discovered.

Relevant infra should be updated to prevent this type of regressions.
@NikolaMilosavljevic NikolaMilosavljevic changed the title Poison infra is not scanning sdk tarball Poison infra is not scanning the SDK tarball Apr 15, 2025
@NikolaMilosavljevic NikolaMilosavljevic self-assigned this Apr 15, 2025
@mthalman mthalman added area-poison Poison leaks and the leak detection infrastructure and removed untriaged labels Apr 17, 2025
@mthalman mthalman moved this from Backlog to In Progress in .NET Source Build Apr 17, 2025
This was referenced Apr 17, 2025
Closed
Closed
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Apr 25, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-poison Poison leaks and the leak detection infrastructure
Projects
.NET Source Build
Archived in project
Milestone
No milestone
2 participants
@NikolaMilosavljevic @mthalman