Updates from review comments

Author: mthalman

src/referencePackageSourceGenerator/ReferencePackageProjectTemplate.xml

@@ -9,7 +9,7 @@
     <OutputPath>$(ArtifactsBinDir)$$RelativePath$$/ref/</OutputPath>
     <IntermediateOutputPath>$(ArtifactsObjDir)$$RelativePath$$</IntermediateOutputPath>
   </PropertyGroup>
-$$PropertiesByTfm$$  <ItemGroup>
+$$TfmSpecificProperties$$  <ItemGroup>
     <Compile Include="**/ref/$(TargetFramework)/*.cs" />
     <Compile Include="**/lib/$(TargetFramework)/*.cs" />
   </ItemGroup>

src/referencePackageSourceGenerator/ReferencePackageSourceGenerator.proj

@@ -7,7 +7,10 @@
     <PackagesTargetDirectory>$(RepoRoot)src\referencePackages\src\</PackagesTargetDirectory>
     <!-- The following target frameworks aren't buildable with the current SDK and as they don't contribute to the set of
          source build target verticals, can be safely excluded. -->
-    <ExcludeTargetFrameworks>netcoreapp3.1;netcore50;net463;portable-*;xamarin*;monotouch*;monoandroid*;win8;wp8;wpa81</ExcludeTargetFrameworks>
+    <ExcludeTargetFrameworks>netcore50;net463;portable-*;xamarin*;monotouch*;monoandroid*;win8;wp8;wpa81</ExcludeTargetFrameworks>
+    <!-- The following target frameworks should be excluded even though they are supported by the current SDK because there is no need to have them.
+         Only exclude them when target frameworks to include aren't provided. -->
+    <ExcludeTargetFrameworks Condition="'$(IncludeTargetFrameworks)' == ''">$(ExcludeTargetFrameworks);netcoreapp3.1</ExcludeTargetFrameworks>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(PackageName)' != '' and '$(PackageVersion)' != ''">

src/referencePackageSourceGenerator/ReferencePackageSourceTask/GenerateProject.cs

@@ -40,7 +40,7 @@ public override bool Execute()
             string projectTemplateContent = File.ReadAllText(ProjectTemplate);
             string pkgProjectOutput = projectTemplateContent;
             string packageReferenceIncludes = "\n";
-            string propertiesByTfm = "\n";
+            string tfmSpecificProperties = "\n";
 
             // Make sure that we always use the same directory separator.
             string relativePath = Path.GetRelativePath(BaseTargetPath, Path.GetDirectoryName(TargetPath)).Replace('\\', '/');
@@ -55,7 +55,7 @@ public override bool Execute()
                 string packageReferences = "";
                 string netStandardTag = "NETStandardImplicitPackageVersion";
 
-                if (targetFramework == "netstandard2.0" && !includesNetStandard21 && !includesNetCoreApp30)
+                if (targetFramework == "netstandard2.0")
                 {
                     packageReferences += $"    <PackageReference Include=\"NETStandard.Library\" Version=\"$({netStandardTag})\" />\n";
                 }
@@ -135,19 +135,18 @@ public override bool Execute()
                     }
                 }
 
-                propertiesByTfm += $"  <PropertyGroup Condition=\" '$(TargetFramework)' == '{targetFramework}' \">\n";
+                tfmSpecificProperties += $"  <PropertyGroup Condition=\" '$(TargetFramework)' == '{targetFramework}' \">\n";
                 if (subPath == "lib")
                 {
-                    propertiesByTfm += $"    <OutputPath>$(ArtifactsBinDir){relativePath}/{subPath}/</OutputPath>\n";
+                    tfmSpecificProperties += $"    <OutputPath>$(ArtifactsBinDir){relativePath}/{subPath}/</OutputPath>\n";
                 }
-                if (targetFramework == "netstandard2.0" ||
-                    targetFramework == "netstandard2.1" ||
+                if (targetFramework == "netstandard2.1" ||
                     targetFramework == "netcoreapp3.0" ||
                     targetFramework == "net6.0")
                 {
-                    propertiesByTfm += "    <DisableImplicitFrameworkReferences>false</DisableImplicitFrameworkReferences>\n";
+                    tfmSpecificProperties += "    <DisableImplicitFrameworkReferences>false</DisableImplicitFrameworkReferences>\n";
                 }
-                propertiesByTfm += $"  </PropertyGroup>\n\n";
+                tfmSpecificProperties += $"  </PropertyGroup>\n\n";
             }
 
             // If necessary, write the strong name key into the project file.
@@ -159,7 +158,7 @@ public override bool Execute()
             }
 
             pkgProjectOutput = pkgProjectOutput.Replace("$$LowerCaseFileName$$", PackageId.ToLowerInvariant());
-            pkgProjectOutput = pkgProjectOutput.Replace("$$PropertiesByTfm$$", propertiesByTfm);
+            pkgProjectOutput = pkgProjectOutput.Replace("$$TfmSpecificProperties$$", tfmSpecificProperties);
             pkgProjectOutput = pkgProjectOutput.Replace("$$RelativePath$$", relativePath);
             pkgProjectOutput = pkgProjectOutput.Replace("$$PackageReferences$$", packageReferenceIncludes);
             pkgProjectOutput = pkgProjectOutput.Replace("$$TargetFrameworks$$", string.Join(';', orderedTargetFrameworks));