Skip to content

Commit 68ef163

Browse files
authored
Merge pull request #6232 from dotnet/merges/release-to-main
Merge release to main
2 parents 002c58d + f4b7db4 commit 68ef163

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

CHANGELOG.md

+18
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,24 @@
99
- Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)
1010

1111
## Latest
12+
* Fix UriFormatException during dotnet SDK resolution when symlinks are involved (PR: [#6230](https://github.com/dotnet/vscode-csharp/pull/6230))
13+
14+
## 2.0.413
15+
* Update Roslyn version (PR: [#6192](https://github.com/dotnet/vscode-csharp/pull/6192))
16+
* Add support for compilation end diagnostics (PR: [#69541](https://github.com/dotnet/roslyn/pull/69541))
17+
* Include CodeLens on more types and members (PR: [#69608](https://github.com/dotnet/roslyn/pull/69608))
18+
* Improve performance when computing colorization (PR: [#69496](https://github.com/dotnet/roslyn/pull/69496))
19+
* Fix dotnet resolver returning incorrect runtime in certain scenarios (PR: [#6180](https://github.com/dotnet/vscode-csharp/pull/6180))
20+
* Fix issue resolving .NET 7 runtimes from path (PR: [#6175](https://github.com/dotnet/vscode-csharp/pull/6175))
21+
* Fix URI issue when loading Razor files (PR: [#6168](https://github.com/dotnet/vscode-csharp/pull/6168))
22+
* Bump Razor to 7.0.0-preview.23417.3 (PR: [#6165](https://github.com/dotnet/vscode-csharp/pull/6165))
23+
* Fix various textDocument/foldingRange issues (PR: [#9134](https://github.com/dotnet/razor/pull/9134))
24+
* Clarify dotnet path option description (PR: [#6164](https://github.com/dotnet/vscode-csharp/pull/6164))
25+
* Handle multiple dotnet on path and symlinks (PR: [#6152](https://github.com/dotnet/vscode-csharp/pull/6152))
26+
* Localize Roslyn options (PR: [#6136](https://github.com/dotnet/vscode-csharp/pull/6136))
27+
* Show a prompt if we have more than one solution file (PR: [#6132](https://github.com/dotnet/vscode-csharp/pull/6132))
28+
29+
## 2.0.376
1230
* Update Roslyn (PR: [#6131](https://github.com/dotnet/vscode-csharp/pull/6131))
1331
* Only show toast for project load failures (PR: [#69494](https://github.com/dotnet/roslyn/pull/69494))
1432
* Fix enter inserting /// on the incorrect line in documentation comments (PR: [#6130](https://github.com/dotnet/vscode-csharp/pull/6130))

src/lsptoolshost/dotnetRuntimeExtensionResolver.ts

+2-8
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { CSharpExtensionId } from '../constants/csharpExtensionId';
1515
import { promisify } from 'util';
1616
import { exec } from 'child_process';
1717
import { getDotnetInfo } from '../shared/utils/getDotnetInfo';
18-
import { readFile, readlink } from 'fs/promises';
18+
import { readFile, realpath } from 'fs/promises';
1919

2020
export const DotNetRuntimeVersion = '7.0';
2121

@@ -183,13 +183,7 @@ export class DotnetRuntimeExtensionResolver implements IHostExecutableResolver {
183183

184184
// If dotnet is just a symlink, resolve it to the actual executable so
185185
// callers will be able to get the actual directory containing the exe.
186-
try {
187-
const targetPath = await readlink(path);
188-
return targetPath;
189-
} catch {
190-
// Not a symlink.
191-
return path;
192-
}
186+
return await realpath(path);
193187
} catch (e) {
194188
this.channel.appendLine(
195189
'Failed to find dotnet info from path, falling back to acquire runtime via ms-dotnettools.vscode-dotnet-runtime'

0 commit comments

Comments
 (0)