Remove ternary operator

Author: nagilson

vscode-dotnet-runtime-library/src/EventStream/EventStreamEvents.ts

@@ -330,8 +330,7 @@ export class DotnetAcquisitionInProgress extends IEvent {
     constructor(public readonly version: string, public readonly requestingExtensionId: string | null) { super(); }
 
     public getProperties() {
-        return {InProgressInstallationVersion : this.version, extensionId : this.requestingExtensionId != null ?
-            TelemetryUtilities.HashData(this.requestingExtensionId) : ''};
+        return {InProgressInstallationVersion : this.version, extensionId : TelemetryUtilities.HashData(this.requestingExtensionId)};
     }
 }
 
@@ -342,8 +341,7 @@ export class DotnetAcquisitionAlreadyInstalled extends IEvent {
     constructor(public readonly version: string, public readonly requestingExtensionId: string | null) { super(); }
 
     public getProperties() {
-        return {AlreadyInstalledVersion : this.version, extensionId : this.requestingExtensionId != null ?
-            TelemetryUtilities.HashData(this.requestingExtensionId) : ''};
+        return {AlreadyInstalledVersion : this.version, extensionId : TelemetryUtilities.HashData(this.requestingExtensionId)};
     }
 }
 

vscode-dotnet-runtime-library/src/EventStream/TelemetryUtilities.ts

@@ -9,8 +9,13 @@ import { TextEncoder } from 'util';
 
 export class TelemetryUtilities
 {
-    public static HashData(dataToHash: string) : string
+    public static HashData(dataToHash: string | null) : string
     {
+        if(!dataToHash)
+        {
+            return '';
+        }
+
         const hasher = crypto.createHash('sha256');
         const utf8Bytes = new TextEncoder().encode(dataToHash.toUpperCase());
         const hashedData = hasher.update(utf8Bytes).digest('hex').toLowerCase();