handle directories in /dev/disk/by-path #2592
Labels
bug
Our bugs
Comments
aafeijoo-suse
added a commit
to aafeijoo-suse/dracut
that referenced
this issue
Dec 19, 2023
…rror If `find_block_device` returns an error, the device must not be added to the list of host devices. E.g., a system with /etc mounted as overlay is pushing the empty string '' as host device. ``` //usr/bin/dracut@1658(): readlink -f /etc /usr/bin/dracut@1658(): mp=/etc /usr/bin/dracut@1659(): mountpoint /etc //usr/bin/dracut@1660(): find_block_device /etc //usr/lib/dracut/dracut-functions.sh@366(find_block_device): local _dev _majmin _find_mpt //usr/lib/dracut/dracut-functions.sh@367(find_block_device): _find_mpt=/etc //usr/lib/dracut/dracut-functions.sh@369(find_block_device): [[ '' != yes ]] //usr/lib/dracut/dracut-functions.sh@370(find_block_device): [[ -d /etc/. ]] //usr/lib/dracut/dracut-functions.sh@371(find_block_device): findmnt -e -v -n -o MAJ:MIN,SOURCE --target /etc //usr/lib/dracut/dracut-functions.sh@372(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@373(find_block_device): [[ -b overlay ]] //usr/lib/dracut/dracut-functions.sh@384(find_block_device): [[ overlay == *:* ]] //usr/lib/dracut/dracut-functions.sh@372(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@372(find_block_device): '[' -n '' ']' //usr/lib/dracut/dracut-functions.sh@389(find_block_device): return 1 //usr/lib/dracut/dracut-functions.sh@393(find_block_device): [[ ! -f /etc/fstab ]] //usr/lib/dracut/dracut-functions.sh@395(find_block_device): findmnt -e --fstab -v -n -o MAJ:MIN,SOURCE --target /etc //usr/lib/dracut/dracut-functions.sh@396(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@397(find_block_device): [[ -n '' ]] //usr/lib/dracut/dracut-functions.sh@398(find_block_device): _dev=overlay //usr/lib/dracut/dracut-functions.sh@399(find_block_device): unset _majmin //usr/lib/dracut/dracut-functions.sh@401(find_block_device): [[ -b overlay ]] //usr/lib/dracut/dracut-functions.sh@410(find_block_device): [[ overlay == *:* ]] //usr/lib/dracut/dracut-functions.sh@396(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@396(find_block_device): '[' -n '' ']' //usr/lib/dracut/dracut-functions.sh@415(find_block_device): return 1 //usr/lib/dracut/dracut-functions.sh@418(find_block_device): return 1 /usr/bin/dracut@1660(): _dev= //usr/bin/dracut@1661(): readlink -f /dev/block/ /usr/bin/dracut@1661(): _bdev=/dev/block /usr/bin/dracut@1662(): [[ -b /dev/block ]] /usr/bin/dracut@1663(): [[ /etc == \/ ]] /usr/bin/dracut@1664(): push_host_devs '' ``` Fixes dracutdevs#2592
3 tasks
Merged
3 tasks
ReillyBrogan
pushed a commit
to getsolus/dracut
that referenced
this issue
May 18, 2024
…rror If `find_block_device` returns an error, the device must not be added to the list of host devices. E.g., a system with /etc mounted as overlay is pushing the empty string '' as host device. ``` //usr/bin/dracut@1658(): readlink -f /etc /usr/bin/dracut@1658(): mp=/etc /usr/bin/dracut@1659(): mountpoint /etc //usr/bin/dracut@1660(): find_block_device /etc //usr/lib/dracut/dracut-functions.sh@366(find_block_device): local _dev _majmin _find_mpt //usr/lib/dracut/dracut-functions.sh@367(find_block_device): _find_mpt=/etc //usr/lib/dracut/dracut-functions.sh@369(find_block_device): [[ '' != yes ]] //usr/lib/dracut/dracut-functions.sh@370(find_block_device): [[ -d /etc/. ]] //usr/lib/dracut/dracut-functions.sh@371(find_block_device): findmnt -e -v -n -o MAJ:MIN,SOURCE --target /etc //usr/lib/dracut/dracut-functions.sh@372(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@373(find_block_device): [[ -b overlay ]] //usr/lib/dracut/dracut-functions.sh@384(find_block_device): [[ overlay == *:* ]] //usr/lib/dracut/dracut-functions.sh@372(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@372(find_block_device): '[' -n '' ']' //usr/lib/dracut/dracut-functions.sh@389(find_block_device): return 1 //usr/lib/dracut/dracut-functions.sh@393(find_block_device): [[ ! -f /etc/fstab ]] //usr/lib/dracut/dracut-functions.sh@395(find_block_device): findmnt -e --fstab -v -n -o MAJ:MIN,SOURCE --target /etc //usr/lib/dracut/dracut-functions.sh@396(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@397(find_block_device): [[ -n '' ]] //usr/lib/dracut/dracut-functions.sh@398(find_block_device): _dev=overlay //usr/lib/dracut/dracut-functions.sh@399(find_block_device): unset _majmin //usr/lib/dracut/dracut-functions.sh@401(find_block_device): [[ -b overlay ]] //usr/lib/dracut/dracut-functions.sh@410(find_block_device): [[ overlay == *:* ]] //usr/lib/dracut/dracut-functions.sh@396(find_block_device): read -r _majmin _dev //usr/lib/dracut/dracut-functions.sh@396(find_block_device): '[' -n '' ']' //usr/lib/dracut/dracut-functions.sh@415(find_block_device): return 1 //usr/lib/dracut/dracut-functions.sh@418(find_block_device): return 1 /usr/bin/dracut@1660(): _dev= //usr/bin/dracut@1661(): readlink -f /dev/block/ /usr/bin/dracut@1661(): _bdev=/dev/block /usr/bin/dracut@1662(): [[ -b /dev/block ]] /usr/bin/dracut@1663(): [[ /etc == \/ ]] /usr/bin/dracut@1664(): push_host_devs '' ``` Fixes dracutdevs#2592
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
systemd/systemd#29219 introduced directories like
/dev/disk/by-path/pci-0000:00:03.0-part/. Dracut seems to always include those in built initrds. Booting such an initrd then indefinitely waits for the device to appear. So boot never continues as it's not actually a device.The culprit might be
get_maj_min(). There's no error condition for calling stat on a non-device:So the function just prints
0:0too while calling code seems to expect an emtpy reply.The text was updated successfully, but these errors were encountered: