Skip to content

Commit 53f3361

Browse files
malfetpytorchmergebot
authored andcommitted
[BE] Use nested namespaces for sparse (pytorch#117415)
C++17 is fu Pull Request resolved: pytorch#117415 Approved by: https://github.com/Skylion007
1 parent d8bdb50 commit 53f3361

23 files changed

+48
-106
lines changed

aten/src/ATen/native/sparse/ParamUtils.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
#include <ATen/TensorUtils.h>
55
#include <tuple>
66

7-
namespace at {
8-
namespace native {
7+
namespace at::native {
98

109
TORCH_API std::tuple<Tensor, Tensor, int64_t> softmax_sparse_input_preprocessing(
1110
const Tensor& input_,
@@ -20,5 +19,4 @@ TORCH_API std::tuple<Tensor, Tensor, Tensor, int64_t> softmax_backward_sparse_in
2019
const Tensor& input_,
2120
CheckedFrom function_name);
2221

23-
} // namespace native
24-
} // namespace at
22+
} // namespace at::native

aten/src/ATen/native/sparse/SparseBinaryOpIntersectionCommon.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
#define NAME "sparse_binary_op_intersection_cpu"
2424
#endif
2525

26-
namespace at {
27-
namespace native {
26+
namespace at::native {
2827

2928
namespace {
3029

@@ -478,4 +477,4 @@ void _sparse_binary_op_intersection_kernel_out(
478477

479478
} // anonymous namespace
480479

481-
}} // at::native
480+
} // at::native

aten/src/ATen/native/sparse/SparseBlas.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
#include <ATen/Tensor.h>
66
#include <ATen/core/Scalar.h>
77

8-
namespace at {
9-
namespace native {
10-
namespace sparse {
8+
namespace at::native::sparse {
119

1210
TORCH_API void sparse_sampled_addmm_check_inputs(
1311
const Tensor& self,
@@ -17,6 +15,4 @@ TORCH_API void sparse_sampled_addmm_check_inputs(
1715
const Scalar& alpha,
1816
const Tensor& result);
1917

20-
} // namespace sparse
21-
} // namespace native
22-
} // namespace at
18+
} // namespace at::native::sparse

aten/src/ATen/native/sparse/SparseBlasImpl.h

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
#include <ATen/Tensor.h>
44
#include <ATen/core/Scalar.h>
55

6-
namespace at {
7-
namespace native {
8-
namespace sparse {
9-
namespace impl {
6+
namespace at::native::sparse::impl {
107

118
TORCH_API Tensor& _compressed_row_strided_mm_out(
129
const Tensor& compressed_row_sparse,
@@ -45,7 +42,4 @@ void triangular_solve_out_sparse_csr(
4542
bool unitriangular);
4643

4744
} // namespace cpu
48-
} // namespace impl
49-
} // namespace sparse
50-
} // namespace native
51-
} // namespace at
45+
} // namespace at::native::sparse::impl

aten/src/ATen/native/sparse/SparseCsrTensorMath.h

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,7 @@
66
#include <ATen/native/ReductionType.h>
77
#include <ATen/native/cpu/SpmmReduceKernel.h>
88

9-
namespace at {
10-
namespace native {
11-
namespace sparse {
12-
namespace impl {
9+
namespace at::native::sparse::impl {
1310

1411
// Returns true if all entries of self are zero
1512
// TODO: This has potential to be a generic helper
@@ -84,7 +81,4 @@ inline void check_sparse_mm_reduce_impl_inputs(
8481
check_dim_size(other, 2, 0, self.size(1));
8582
}
8683

87-
}
88-
}
89-
}
90-
}
84+
} // at::native::sparse::impl

aten/src/ATen/native/sparse/SparseStubs.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,5 @@ DECLARE_DISPATCH(sparse_mask_projection_out_fn, sparse_mask_projection_out_stub)
2222
using flatten_indices_fn = Tensor (*)(const Tensor& indices, IntArrayRef size);
2323
DECLARE_DISPATCH(flatten_indices_fn, flatten_indices_stub);
2424

25-
}
26-
27-
}
25+
} // namespace native
26+
} // namespace at

aten/src/ATen/native/sparse/SparseTensorMath.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
#include <ATen/native/SparseTensorUtils.h>
44

5-
namespace at { namespace native {
5+
namespace at::native {
66

77
TORCH_API sparse::SparseTensor& mul_out_sparse_scalar(sparse::SparseTensor& r, const sparse::SparseTensor& t, const Scalar& value);
88
TORCH_API sparse::SparseTensor& mul_out_sparse_zerodim(sparse::SparseTensor& r, const sparse::SparseTensor& t, const Tensor& value);
99
TORCH_API sparse::SparseTensor& _mul_dense_sparse_out(const Tensor& d, const Tensor& s, Tensor& res);
1010
TORCH_API sparse::SparseTensor& _mul_sparse_sparse_zero_dim_out(const Tensor& zero_dim, const Tensor& other, Tensor& res);
1111
TORCH_API sparse::SparseTensor& _mul_sparse_sparse_out(const Tensor& x, const Tensor& y, Tensor& res);
1212

13-
}}
13+
} // namespace at::native

aten/src/ATen/native/sparse/ValidateCompressedIndicesCommon.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@
2424

2525
#define INVARIANT_CHECK_FUNC_API static INLINE FUNCAPI void
2626

27-
namespace at {
28-
namespace native {
27+
namespace at::native {
2928

3029
namespace {
3130

@@ -412,5 +411,4 @@ void validate_compressed_sparse_indices_kernel(
412411

413412
} // namespace
414413

415-
} // namespace native
416-
} // namespace at
414+
} // namespace at::native

aten/src/ATen/native/sparse/cuda/SoftMax.cu

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@
6161

6262
#include <c10/cuda/CUDAMathCompat.h>
6363

64-
namespace at {
65-
namespace native {
64+
namespace at::native {
6665
namespace {
6766

6867
// Number of threads in a block given an input size up to MAX_BLOCK_SIZE
@@ -669,5 +668,4 @@ Tensor log_softmax_backward_sparse_cuda(
669668
return grad_input;
670669
}
671670

672-
} // namespace native
673-
} // namespace at
671+
} // namespace at::native

aten/src/ATen/native/sparse/cuda/SparseBlas.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@
2424

2525
#include <c10/util/MaybeOwned.h>
2626

27-
namespace at {
28-
namespace native {
27+
namespace at::native {
2928

3029
/*
3130
Computes `result` <- α*(A @ B) * spy(C) + β*C, where spy(C) is the sparsity pattern matrix of C.
@@ -285,5 +284,4 @@ std::tuple<Tensor&, Tensor&> triangular_solve_out_sparse_csr_cuda(
285284
return std::tuple<Tensor&, Tensor&>(X, clone_A);
286285
}
287286

288-
} // namespace native
289-
} // namespace at
287+
} // namespace at::native

0 commit comments

Comments
 (0)