Issue #2931559 by chrisolof: $sandwich_plugin_info should be passed by reference

Author: chrisolof

plugin_type_example/plugin_type_example.api.php

@@ -16,7 +16,7 @@
  * @param array $sandwich_plugin_info
  *   This is the array of plugin definitions.
  */
-function hook_sandwich_info_alter(array $sandwich_plugin_info) {
+function hook_sandwich_info_alter(array &$sandwich_plugin_info) {
   // Let's change the 'foobar' property for all sandwiches.
   foreach ($sandwich_plugin_info as $plugin_id => $plugin_definition) {
     $sandwich_plugin_info[$plugin_id]['foobar'] = t('We have altered this in the alter hook');

plugin_type_example/tests/src/Functional/PluginTypeExampleTest.php

@@ -32,7 +32,7 @@ class PluginTypeExampleTest extends ExamplesBrowserTestBase {
   /**
    * Test the plugin manager can be loaded, and the plugins are registered.
    *
-   * @todo: Check the alter hook fired and changed a property.
+   * @todo: https://www.drupal.org/project/examples/issues/2985705
    */
   public function testPluginExample() {
     /* @var $manager \Drupal\plugin_type_example\SandwichPluginManager */