Coding standards cleanup.

Author: paul-m

dbtng_example/dbtng_example.install

@@ -22,8 +22,8 @@ function dbtng_example_install() {
     'age' => 0,
   );
   db_insert('dbtng_example')
-      ->fields($fields)
-      ->execute();
+    ->fields($fields)
+    ->execute();
 
   // Add another entry.
   $fields = array(
@@ -33,8 +33,8 @@ function dbtng_example_install() {
     'uid' => 1,
   );
   db_insert('dbtng_example')
-      ->fields($fields)
-      ->execute();
+    ->fields($fields)
+    ->execute();
 }
 
 /**

dbtng_example/src/DbtngExampleStorage.php

@@ -28,7 +28,7 @@ class DbtngExampleStorage {
    *
    * @see db_insert()
    */
-  public static function insert($entry) {
+  public static function insert(array $entry) {
     $return_value = NULL;
     try {
       $return_value = db_insert('dbtng_example')
@@ -56,13 +56,13 @@ public static function insert($entry) {
    *
    * @see db_update()
    */
-  public static function update($entry) {
+  public static function update(array $entry) {
     try {
       // db_update()...->execute() returns the number of rows updated.
       $count = db_update('dbtng_example')
-          ->fields($entry)
-          ->condition('pid', $entry['pid'])
-          ->execute();
+        ->fields($entry)
+        ->condition('pid', $entry['pid'])
+        ->execute();
     }
     catch (\Exception $e) {
       drupal_set_message(t('db_update failed. Message = %message, query= %query', array(
@@ -83,10 +83,10 @@ public static function update($entry) {
    *
    * @see db_delete()
    */
-  public static function delete($entry) {
+  public static function delete(array $entry) {
     db_delete('dbtng_example')
-        ->condition('pid', $entry['pid'])
-        ->execute();
+      ->condition('pid', $entry['pid'])
+      ->execute();
   }
 
   /**
@@ -161,7 +161,7 @@ public static function delete($entry) {
    * @see http://drupal.org/node/310072
    * @see http://drupal.org/node/310075
    */
-  public static function load($entry = array()) {
+  public static function load(array $entry = array()) {
     // Read all fields from the dbtng_example table.
     $select = db_select('dbtng_example', 'example');
     $select->fields('example');

field_example/tests/src/Functional/ColorBackgroundFormatterTest.php

@@ -51,6 +51,8 @@ public function testSingleValueField() {
   }
 
   /**
+   * Tests a multi-value field.
+   *
    * Test the following scenarios in Field example:
    * - Creates a content type.
    * - Adds a multivalued field_example_rgb to it.

file_example/src/Form/FileExampleReadWriteForm.php

@@ -400,6 +400,8 @@ public function buildForm(array $form, FormStateInterface $form_state) {
    *    * @param array $form
    *   An associative array containing the structure of the form.
    *
+   * @param array &$form
+   *   The form array.
    * @param \Drupal\Core\Form\FormStateInterface $form_state
    *   The current state of the form.
    */
@@ -463,6 +465,8 @@ public function handleManagedFile(array &$form, FormStateInterface $form_state)
    *    * @param array $form
    *   An associative array containing the structure of the form.
    *
+   * @param array &$form
+   *   The form array.
    * @param \Drupal\Core\Form\FormStateInterface $form_state
    *   The current state of the form.
    */

hooks_example/hooks_example.module

@@ -5,11 +5,11 @@
  * Examples demonstrating how to implement and invoke hooks.
  */
 
-use \Drupal\Core\Entity\Display\EntityViewDisplayInterface;
-use \Drupal\Core\Entity\EntityInterface;
-use \Drupal\Core\Form\FormStateInterface;
-use \Drupal\node\NodeInterface;
-use \Drupal\Core\Routing\RouteMatchInterface;
+use Drupal\Core\Entity\Display\EntityViewDisplayInterface;
+use Drupal\Core\Entity\EntityInterface;
+use Drupal\Core\Form\FormStateInterface;
+use Drupal\node\NodeInterface;
+use Drupal\Core\Routing\RouteMatchInterface;
 
 /**
  * @defgroup hooks_example Example: Hooks

phpunit_example/tests/src/Unit/DisplayManagerTest.php

@@ -40,8 +40,8 @@ public function testSimpleMockDisplayManager() {
     // expects($this->any()) tells the mock to return this value any time
     // the method is called.
     $mock->expects($this->any())
-        ->method('getDisplayName')
-        ->will($this->returnValue('the display name'));
+      ->method('getDisplayName')
+      ->will($this->returnValue('the display name'));
 
     // Create a DisplayManager, the class we're actually testing here.
     $dm = new DisplayManager();

queue_example/src/Forms/QueueExampleForm.php

@@ -53,6 +53,10 @@ class QueueExampleForm extends FormBase {
    *   Queue factory service to get new/existing queues for use.
    * @param \Drupal\Core\Database\Connection $database
    *   The database connection to be used.
+   * @param Drupal\Core\CronInterface $cron
+   *   The cron service.
+   * @param Drupal\Core\Site\Settings $settings
+   *   The site settings.
    */
   public function __construct(QueueFactory $queue_factory, Connection $database, CronInterface $cron, Settings $settings) {
     $this->queueFactory = $queue_factory;

stream_wrapper_example/src/StreamWrapper/FileExampleSessionStreamWrapper.php

@@ -265,7 +265,7 @@ protected function getLocalPath($uri = NULL) {
       $uri = $this->uri;
     }
 
-    $path  = str_replace('session://', '', $uri);
+    $path = str_replace('session://', '', $uri);
     $path = trim($path, '/');
     return $path;
   }
@@ -657,7 +657,7 @@ public function rename($from_uri, $to_uri) {
    */
   public function dirname($uri = NULL) {
     list($scheme, $target) = explode('://', $uri, 2);
-    $target  = $this->getTarget($uri);
+    $target = $this->getTarget($uri);
     if (strpos($target, '/')) {
       $dirname = preg_replace('@/[^/]*$@', '', $target);
     }

stream_wrapper_example/src/StreamWrapper/SessionWrapper.php

@@ -42,7 +42,7 @@ public function __construct(RequestStack $request_stack) {
   /**
    * Get a fresh session object.
    *
-   * @return SessionInterface
+   * @return \Symfony\Component\HttpFoundation\Session\SessionInterface
    *   A session object.
    */
   protected function getSession() {
@@ -72,7 +72,7 @@ protected function getStore() {
    *   The content of the whole session data store, to replace all of the
    *   current data.
    */
-  protected function setStore($store) {
+  protected function setStore(array $store) {
     $session = $this->getSession();
     $session->set(static::SESSION_BASE_ATTRIBUTE, $store);
   }

tour_example/src/Controller/TourExampleController.php

@@ -20,4 +20,5 @@ class TourExampleController {
   protected function getModuleName() {
     return 'tour_example';
   }
+
 }

tour_example/tests/src/Functional/TourTestBase.php

@@ -31,7 +31,7 @@ abstract class TourTestBase extends ExamplesBrowserTestBase {
    * $this->assertTourTips($tips);
    * @endcode
    */
-  public function assertTourTips($tips = array()) {
+  public function assertTourTips(array $tips = array()) {
     $assert = $this->assertSession();
     // Get the rendered tips and their data-id and data-class attributes.
     if (empty($tips)) {