Skip to content

Use the SensitiveParameter attribute on sensitive arguments #6549

@Rudloff

Description

@Rudloff

Is your feature request related to a problem? Please describe.
Some Drush methods take sensitive values (passwords for example) as arguments.
If the method throws an exception, these could leak to the stack trace (in CI logs for exampl)e.

Some examples of methods with sensitive arguments:

  • SiteInstallCommands::install()
  • SyncViaHttpCommands::downloadFile()

Describe the solution you'd like
We should identify sensitive arguments and add #[SensitiveParameter].

Describe alternatives you've considered
A workaround is to disable argument values in stack traces (zend.exception_ignore_args PHP setting).

Additional context
https://www.php.net/manual/en/class.sensitiveparameter.php

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions