Skip to content

Commit 6166317

Browse files
authored
Merge pull request #26 from drzo/alert-autofix-7
Fix code scanning alert no. 7: Insecure randomness
2 parents 5f07491 + 322933c commit 6166317

File tree

1 file changed

+6
-5
lines changed
  • influent-client/influent-clientjs/src/scripts/lib/util

1 file changed

+6
-5
lines changed

influent-client/influent-clientjs/src/scripts/lib/util/GUID.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,14 @@ define(
2525

2626
guid.generateGuid = function () {
2727
var result = '';
28-
for (var i = 0; i < 32; i++) {
29-
if (i === 8 || i === 12 || i === 16 || i === 20) {
30-
result = result + '-';
28+
var array = new Uint8Array(16);
29+
window.crypto.getRandomValues(array);
30+
for (var i = 0; i < array.length; i++) {
31+
if (i === 4 || i === 6 || i === 8 || i === 10) {
32+
result += '-';
3133
}
32-
result = result + Math.floor(Math.random() * 16).toString(16).toUpperCase();
34+
result += array[i].toString(16).padStart(2, '0').toUpperCase();
3335
}
34-
3536
return result;
3637
};
3738

0 commit comments

Comments
 (0)