Update dependencies, eslint.

Author: dscalzi

.eslintignore

@@ -0,0 +1,64 @@
+// @ts-check
+
+const eslint = require('@eslint/js');
+const tseslint = require('typescript-eslint');
+const stylisticTs = require('@stylistic/eslint-plugin-ts');
+const { join } = require('path');
+
+module.exports = tseslint.config(
+  {
+    ignores: ['**/dist/**', 'node_modules', 'eslint.config.cjs'],
+  },
+  eslint.configs.recommended,
+  ...tseslint.configs.recommendedTypeChecked,
+  ...tseslint.configs.stylisticTypeChecked,
+  {
+    files: ['**/*.{ts,mts,cts,tsx}'],
+    plugins: {
+      // @ts-ignore
+      '@stylistic/ts': stylisticTs,
+      '@typescript-eslint': tseslint.plugin,
+    },
+    languageOptions: {
+      parser: tseslint.parser,
+      parserOptions: {
+        project: [
+          join(__dirname, 'tsconfig.json'),
+          join(__dirname, 'tsconfig.test.json')
+        ]
+      },
+    },
+    rules: {
+      '@stylistic/ts/semi': ['error', 'never'],
+      '@stylistic/ts/quotes': ['error', 'single'],
+      '@stylistic/ts/indent': ['error', 4],
+      '@stylistic/ts/member-delimiter-style': ['error', {
+        multiline: {
+          delimiter: 'none',
+          requireLast: false
+        },
+        singleline: {
+          delimiter: 'comma',
+          requireLast: false
+        }
+      }],
+      '@typescript-eslint/consistent-indexed-object-style': 'off',  // Don't need to enforce types be Record
+      '@typescript-eslint/explicit-function-return-type': ['warn'], // Warn if no return type is set
+      '@typescript-eslint/no-unsafe-call': 'off',                   // There are instances where internal types are ambigious but it doesnt matter                  
+      '@typescript-eslint/no-unsafe-member-access': 'off',          // Method calls, above reason
+      '@typescript-eslint/no-unused-vars': ['error', {              // Allow unused caught errors
+        'caughtErrors': 'none'
+      }],
+      '@typescript-eslint/prefer-nullish-coalescing': 'off',        // Logical OR is fine depending on the circumstance
+      '@typescript-eslint/prefer-promise-reject-errors': 'off',     // We reject with errors passed through event listeners that are untyped
+      '@typescript-eslint/require-await': 'off',                    // This is literally broken
+      '@typescript-eslint/restrict-template-expressions': 'off'     // We make use of template expressions on objects
+    }
+  },
+  {
+    files: ['test/**/*.ts'],
+    rules: {
+      '@typescript-eslint/no-unused-expressions': 'off'             // Chai uses these
+    }
+  }
+);

.eslintrc.cjs

@@ -68,7 +68,6 @@ export class DistributionIndexProcessor extends IndexProcessor {
         }
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     public async loadModLoaderVersionJson(): Promise<VersionJsonBase> {
 
         const server: HeliosServer = this.distribution.getServerById(this.serverId)!

eslint.config.cjs

@@ -433,8 +433,8 @@ export function rankApplicableJvms(details: JvmDetails[]): void {
                 if(a.semver.patch === b.semver.patch){
 
                     // Same version, give priority to JRE.
-                    if(a.path.toLowerCase().indexOf('jdk') > -1){
-                        return b.path.toLowerCase().indexOf('jdk') > -1 ? 0 : 1
+                    if(a.path.toLowerCase().includes('jdk')){
+                        return b.path.toLowerCase().includes('jdk') ? 0 : 1
                     } else {
                         return -1
                     }
@@ -626,7 +626,7 @@ export async function extractJdk(archivePath: string): Promise<string> {
             // Get the first
             if(javaExecPath == null) {
                 let h = header.name
-                if(h.indexOf('/') > -1){
+                if(h.includes('/')){
                     h = h.substring(0, h.indexOf('/'))
                 }
                 javaExecPath = javaExecFromRoot(join(dirname(archivePath), h))

lib/dl/distribution/DistributionIndexProcessor.ts

@@ -68,7 +68,7 @@ export function decipherErrorCode(body: any): MicrosoftErrorCode {
     if(body) {
         if(body.XErr) {
             const xErr: number = body.XErr as number
-            switch(xErr) {
+            switch(xErr as MicrosoftErrorCode) {
                 case MicrosoftErrorCode.NO_XBOX_ACCOUNT:
                     return MicrosoftErrorCode.NO_XBOX_ACCOUNT
                 case MicrosoftErrorCode.XBL_BANNED:

lib/java/JavaGuard.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-control-regex */
 import { SrvRecord } from 'dns'
 import { resolveSrv } from 'dns/promises'
 import { connect } from 'net'

lib/microsoft/rest/MicrosoftResponse.ts

@@ -145,7 +145,7 @@ export class MojangRestAPI {
      * to our project which represents an unknown status.
      */
     public static statusToHex(status: string): string {
-        switch(status.toLowerCase()){
+        switch(status.toLowerCase() as MojangStatusColor){
             case MojangStatusColor.GREEN:
                 return '#a5c325'
             case MojangStatusColor.YELLOW: