Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 didn't get published to crates.io #89

Closed
OneSadCookie opened this issue Mar 11, 2023 · 4 comments
Closed

1.2.0 didn't get published to crates.io #89

OneSadCookie opened this issue Mar 11, 2023 · 4 comments

Comments

@OneSadCookie
Copy link

release 1.2.0 that I see here in github, didn't get published to crates.io (their latest is 1.1.0)

@dscottboggs
Copy link
Owner

I'm sorry I'll get it out as soon as I can but cargo publish is refusing to publish due to some error which doesn't make sense. It says error: associated function is never used about a bunch of pub associated methods

@OneSadCookie
Copy link
Author

OneSadCookie commented Mar 14, 2023

It's because when built locally, your cargo patch to use your own branch of is_variant is applied, which adds pub correctly, but when published to crates.io, the "real" is_variant crate is used which doesn't have the fix to add that visibility modifier.

If you can get MihirLuthra/is_variant#5 merged (and update your minimum requirement on is_variant), I think 1.2.0 will publish correctly.

@dscottboggs
Copy link
Owner

Thanks for clearing that up. is_variant appears abandoned, I'll try to do something about that today.

@dscottboggs
Copy link
Owner

v1.2.1 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants