Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Permission to Publish ALT-DSS Schema on PyPI #10

Open
AadilLatif opened this issue Dec 30, 2024 · 2 comments
Open

Request for Permission to Publish ALT-DSS Schema on PyPI #10

AadilLatif opened this issue Dec 30, 2024 · 2 comments

Comments

@AadilLatif
Copy link

AadilLatif commented Dec 30, 2024

Hi Paulo,

At NREL, we are currently working on model conversion and have been utilizing the Pydantic models from your repository (NREL-Distribution-Suites/alt-dss-schema). We are now at the stage where we need to package these changes and publish the package on PyPI to add it as a dependency in other projects we are developing.

Until now, we’ve been using the repository internally, but external users are beginning to require access to the package. With your permission, we’d like to proceed with publishing the package and will ensure proper attribution to your work in the repository.

Best regards,
Aadil

@KapilDuwadi

@PMeira
Copy link
Member

PMeira commented Jan 6, 2025

Hi, Aadil (and @KapilDuwadi),

With your permission, we’d like to proceed with publishing the package and will ensure proper attribution to your work in the repository.

Thanks for asking! If you're close to a deadline, go ahead and publish a release on PyPI. If you don't mind adding me as a maintainer, we can cooperate on future releases and try to ensure compatibility.
If you still have some time, I could finally review the changes you guys proposed -- either a PR or a link to the specific branch should work, but of course feel free to drop me an email too.

There are upcoming changes that will affect the schema soon:

  • As usual, there are a few new commands, settings, and components.
  • There are some very recent changes related to the Line and LineGeometry components from the upstream OpenDSS. For example, empty conductors will be allowed, so we won't need to specialize LineGeometries/LineCodes for different number of phases. Thankfully we can reuse the Conductors property as I had proposed here and in AltDSS-Python, just need to allow using None/null for the items.
  • The command system refactoring should be merged by February, with all commands described in the schema.

I don't know if these changes are enough for us to worry about supporting multiple schema versions ("2023-12-13", 2025-01-xx", 2025-02-xx", etc.) in the same package yet, but it's something to think about.

I already ported most of the code related to the changes, and I plan to resume working on testing the upcoming release of the engine and most packages this Monday. Only a few remaining issues to handle.

@AadilLatif
Copy link
Author

Hi Pedro,

Thank you for the response. I will add you as a maintainer.

"If you still have some time, I could finally review the changes you guys proposed -- either a PR or a link to the specific branch should work, but of course feel free to drop me an email too."

That would be awesome. I will work on setting up a repository over the next week.

My colleague Tarek ([email protected]) worked on the changes. He is currently out of office. I will ask him to connect with you once he is back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants