Merge pull request #348 from Mytherin/issue345

Fix #345: support READ_WRITE option correctly

Author: Mytherin

src/postgres_storage.cpp

@@ -21,7 +21,7 @@ static unique_ptr<Catalog> PostgresAttach(StorageExtensionInfo *storage_info, Cl
 	PostgresIsolationLevel isolation_level = PostgresIsolationLevel::REPEATABLE_READ;
 	for (auto &entry : info.options) {
 		auto lower_name = StringUtil::Lower(entry.first);
-		if (lower_name == "type" || lower_name == "read_only") {
+		if (lower_name == "type" || lower_name == "read_only" || lower_name == "read_write") {
 			// already handled
 		} else if (lower_name == "secret") {
 			secret_name = entry.second.ToString();

test/sql/storage/attach_json.test

@@ -12,7 +12,7 @@ statement ok
 PRAGMA enable_verification
 
 statement ok
-ATTACH 'dbname=postgresscanner' AS postgres_db (TYPE POSTGRES)
+ATTACH 'dbname=postgresscanner' AS postgres_db (TYPE POSTGRES, READ_WRITE)
 
 statement ok
 CREATE OR REPLACE TABLE postgres_db.json_tbl AS SELECT '{"a": 42}'::JSON AS json_col