Skip to content

Commit 62b4805

Browse files
authored
Merge pull request #711 from pdet/order_deletion
Order deletions since that's required for deleted files
2 parents 96bb68c + ddc2d20 commit 62b4805

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

src/storage/ducklake_metadata_manager.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2004,7 +2004,8 @@ DuckLakeMetadataManager::ReadAllInlinedDataForFlush(DuckLakeSnapshot snapshot, c
20042004
auto result = transaction.Query(snapshot, StringUtil::Format(R"(
20052005
SELECT %s
20062006
FROM {METADATA_CATALOG}.%s inlined_data
2007-
WHERE {SNAPSHOT_ID} >= begin_snapshot;)",
2007+
WHERE {SNAPSHOT_ID} >= begin_snapshot
2008+
ORDER BY row_id;)",
20082009
projection, inlined_table_name));
20092010
return TransformInlinedData(*result);
20102011
}

test/configs/postgres.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,6 @@
3838
"paths": [
3939
"test/sql/transaction/transaction_conflict_inlining.test"
4040
]
41-
},
42-
{
43-
"reason": "FIXME: Deletion inlining wrong results?",
44-
"paths": [
45-
"test/sql/deletion_inlining/test_deletion_multiple_tables.test",
46-
"test/sql/deletion_inlining/test_deletion_from_inlined_multiple_snapshots.test",
47-
"test/sql/deletion_inlining/test_deletion_from_inlined_insertion.test"
48-
]
4941
}
5042
]
5143
}

0 commit comments

Comments
 (0)