Fix test

aitorvs · aitorvs · commit 9d7610477c64 · 2025-05-07T08:26:15.000+01:00
diff --git a/autoconsent/autoconsent-impl/src/main/java/com/duckduckgo/autoconsent/impl/remoteconfig/AutoconsentExceptionsRepository.kt b/autoconsent/autoconsent-impl/src/main/java/com/duckduckgo/autoconsent/impl/remoteconfig/AutoconsentExceptionsRepository.kt
@@ -53,21 +53,19 @@ class RealAutoconsentExceptionsRepository @Inject constructor(
     override val exceptions = CopyOnWriteArrayList<FeatureException>()
 
     init {
-        coroutineScope.launch(dispatcherProvider.io()) {
-            loadToMemory()
-        }
+        loadToMemory()
     }
 
     private fun loadToMemory() {
-        if (isMainProcess) {
-            exceptions.clear()
-            exceptions.addAll(autoconsentFeature.self().getExceptions())
+        coroutineScope.launch(dispatcherProvider.io()) {
+            if (isMainProcess) {
+                exceptions.clear()
+                exceptions.addAll(autoconsentFeature.self().getExceptions())
+            }
         }
     }
 
     override fun onPrivacyConfigDownloaded() {
-        coroutineScope.launch(dispatcherProvider.io()) {
-            loadToMemory()
-        }
+        loadToMemory()
     }
 }
diff --git a/autoconsent/autoconsent-impl/src/test/java/com/duckduckgo/autoconsent/impl/remoteconfig/RealAutoconsentExceptionsRepositoryTest.kt b/autoconsent/autoconsent-impl/src/test/java/com/duckduckgo/autoconsent/impl/remoteconfig/RealAutoconsentExceptionsRepositoryTest.kt
@@ -16,27 +16,25 @@
 
 package com.duckduckgo.autoconsent.impl.remoteconfig
 
+import android.annotation.SuppressLint
 import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.feature.toggles.api.FakeFeatureToggleFactory
 import com.duckduckgo.feature.toggles.api.FeatureExceptions.FeatureException
 import com.duckduckgo.feature.toggles.api.Toggle
 import kotlinx.coroutines.test.TestScope
 import kotlinx.coroutines.test.runTest
-import org.junit.Assert.*
-import org.junit.Before
+import org.junit.Assert.assertEquals
 import org.junit.Rule
 import org.junit.Test
 
+@SuppressLint("DenyListedApi") // setRawStoredState
 class RealAutoconsentExceptionsRepositoryTest {
 
     @get:Rule
     var coroutineRule = CoroutineTestRule()
 
-    private val autoconsentFeature = FakeFeatureToggleFactory.create(AutoconsentFeature::class.java)
-
-    @Before
-    fun setup() {
-        autoconsentFeature.self().setRawStoredState(Toggle.State(exceptions = listOf(exception)))
+    private val autoconsentFeature: AutoconsentFeature = FakeFeatureToggleFactory.create(AutoconsentFeature::class.java).apply {
+        self().setRawStoredState(Toggle.State(exceptions = exceptions))
     }
 
     @Test
@@ -47,7 +45,8 @@ class RealAutoconsentExceptionsRepositoryTest {
             autoconsentFeature,
             isMainProcess = true,
         )
-        assertEquals(exception, repository.exceptions.first())
+
+        assertEquals(exceptions, repository.exceptions)
     }
 
     @Test
@@ -59,13 +58,13 @@ class RealAutoconsentExceptionsRepositoryTest {
             isMainProcess = true,
         )
 
-        assertEquals(listOf(exception), repository.exceptions)
+        assertEquals(exceptions, repository.exceptions)
         autoconsentFeature.self().setRawStoredState(Toggle.State(exceptions = emptyList()))
         repository.onPrivacyConfigDownloaded()
         assertEquals(emptyList<FeatureException>(), repository.exceptions)
     }
 
     companion object {
-        val exception = FeatureException("example.com", "reason")
+        val exceptions = listOf(FeatureException("example.com", "reason"))
     }
 }
diff --git a/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/email/remoteconfig/RealEmailProtectionInContextFeatureRepositoryTest.kt b/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/email/remoteconfig/RealEmailProtectionInContextFeatureRepositoryTest.kt
@@ -1,5 +1,6 @@
 package com.duckduckgo.autofill.impl.email.remoteconfig
 
+import android.annotation.SuppressLint
 import com.duckduckgo.autofill.impl.email.incontext.EmailProtectionInContextSignupFeature
 import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.feature.toggles.api.FakeFeatureToggleFactory
@@ -11,6 +12,7 @@ import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 
+@SuppressLint("DenyListedApi") // setRawStoredState
 class RealEmailProtectionInContextFeatureRepositoryTest {
     @get:Rule
     var coroutineRule = CoroutineTestRule()
diff --git a/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/feature/plugin/RealAutofillFeatureRepositoryTest.kt b/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/feature/plugin/RealAutofillFeatureRepositoryTest.kt
@@ -1,5 +1,6 @@
 package com.duckduckgo.autofill.impl.feature.plugin
 
+import android.annotation.SuppressLint
 import com.duckduckgo.autofill.api.AutofillFeature
 import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.feature.toggles.api.FakeFeatureToggleFactory
@@ -11,6 +12,7 @@ import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 
+@SuppressLint("DenyListedApi") // setRawStoredState
 class RealAutofillFeatureRepositoryTest {
     @get:Rule
     var coroutineRule = CoroutineTestRule()
diff --git a/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/reporting/remoteconfig/AutofillSiteBreakageReportingFeatureRepositoryImplTest.kt b/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/reporting/remoteconfig/AutofillSiteBreakageReportingFeatureRepositoryImplTest.kt
@@ -1,5 +1,6 @@
 package com.duckduckgo.autofill.impl.reporting.remoteconfig
 
+import android.annotation.SuppressLint
 import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.feature.toggles.api.FakeFeatureToggleFactory
 import com.duckduckgo.feature.toggles.api.FeatureExceptions.FeatureException
@@ -10,6 +11,7 @@ import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 
+@SuppressLint("DenyListedApi") // setRawStoredState
 class AutofillSiteBreakageReportingFeatureRepositoryImplTest {
     @get:Rule
     var coroutineRule = CoroutineTestRule()
diff --git a/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/store/RealAutofillServiceFeatureRepositoryTest.kt b/autofill/autofill-impl/src/test/java/com/duckduckgo/autofill/impl/store/RealAutofillServiceFeatureRepositoryTest.kt
@@ -16,6 +16,7 @@
 
 package com.duckduckgo.autofill.impl.store
 
+import android.annotation.SuppressLint
 import com.duckduckgo.autofill.impl.service.AutofillServiceFeature
 import com.duckduckgo.autofill.impl.service.store.RealAutofillServiceFeatureRepository
 import com.duckduckgo.common.test.CoroutineTestRule
@@ -28,6 +29,7 @@ import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 
+@SuppressLint("DenyListedApi") // setRawStoredState
 class RealAutofillServiceFeatureRepositoryTest {
     @get:Rule
     var coroutineRule = CoroutineTestRule()
diff --git a/malicious-site-protection/malicious-site-protection-impl/src/test/kotlin/com/duckduckgo/malicioussiteprotection/impl/remoteconfig/RealMaliciousSiteProtectionRCRepositoryTest.kt b/malicious-site-protection/malicious-site-protection-impl/src/test/kotlin/com/duckduckgo/malicioussiteprotection/impl/remoteconfig/RealMaliciousSiteProtectionRCRepositoryTest.kt
@@ -1,5 +1,6 @@
 package com.duckduckgo.malicioussiteprotection.impl.remoteconfig
 
+import android.annotation.SuppressLint
 import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.feature.toggles.api.FakeFeatureToggleFactory
 import com.duckduckgo.feature.toggles.api.FeatureExceptions.FeatureException
@@ -11,6 +12,7 @@ import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 
+@SuppressLint("DenyListedApi") // setRawStoredState
 class RealMaliciousSiteProtectionRCRepositoryTest {
     @get:Rule
     var coroutineRule = CoroutineTestRule()
diff --git a/site-permissions/site-permissions-impl/src/test/java/com/duckduckgo/site/permissions/impl/drmblock/RealDrmBlockRepositoryTest.kt b/site-permissions/site-permissions-impl/src/test/java/com/duckduckgo/site/permissions/impl/drmblock/RealDrmBlockRepositoryTest.kt
@@ -1,5 +1,6 @@
 package com.duckduckgo.site.permissions.impl.drmblock
 
+import android.annotation.SuppressLint
 import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.feature.toggles.api.FakeFeatureToggleFactory
 import com.duckduckgo.feature.toggles.api.FeatureExceptions.FeatureException
@@ -10,6 +11,7 @@ import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 
+@SuppressLint("DenyListedApi") // setRawStoredState
 class RealDrmBlockRepositoryTest {
     @get:Rule
     var coroutineRule = CoroutineTestRule()

Original file line number	Diff line number	Diff line change
`@@ -53,21 +53,19 @@ class RealAutoconsentExceptionsRepository @Inject constructor(`
`53`	`53`	`override val exceptions = CopyOnWriteArrayList<FeatureException>()`
`54`	`54`
`55`	`55`	`init {`
`56`		`- coroutineScope.launch(dispatcherProvider.io()) {`
`57`		`- loadToMemory()`
`58`		`- }`
	`56`	`+ loadToMemory()`
`59`	`57`	`}`
`60`	`58`
`61`	`59`	`private fun loadToMemory() {`
`62`		`- if (isMainProcess) {`
`63`		`- exceptions.clear()`
`64`		`- exceptions.addAll(autoconsentFeature.self().getExceptions())`
	`60`	`+ coroutineScope.launch(dispatcherProvider.io()) {`
	`61`	`+ if (isMainProcess) {`
	`62`	`+ exceptions.clear()`
	`63`	`+ exceptions.addAll(autoconsentFeature.self().getExceptions())`
	`64`	`+ }`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`override fun onPrivacyConfigDownloaded() {`
`69`		`- coroutineScope.launch(dispatcherProvider.io()) {`
`70`		`- loadToMemory()`
`71`		`- }`
	`69`	`+ loadToMemory()`
`72`	`70`	`}`
`73`	`71`	`}`