fix: tap export password only once

Author: dbajpeyi

injected/integration-test/autofill-password-import.spec.js

@@ -5,7 +5,7 @@ import { ResultsCollector } from './page-objects/results-collector.js';
 const HTML = '/autofill-password-import/index.html';
 const CONFIG = './integration-test/test-pages/autofill-password-import/config/config.json';
 
-test('Password import feature', async ({ page }, testInfo) => {
+test.only('Password import feature', async ({ page }, testInfo) => {
     const collector = ResultsCollector.create(page, testInfo.project.use);
     await collector.load(HTML, CONFIG);
 

injected/integration-test/test-pages/autofill-password-import/config/config.json

@@ -17,6 +17,7 @@
                 "value": {
                   "settingsButton": {
                     "shouldAutotap": false,
+                    "tapOnce": false,
                     "path": "/",
                     "selectors": [
                       "a[href*='options']"
@@ -27,6 +28,7 @@
                   },
                   "exportButton": {
                     "shouldAutotap": false,
+                    "tapOnce": false,
                     "path": "/options",
                     "selectors": [
                       "c-wiz[data-node-index*='2;0'][data-p*='options']",
@@ -38,6 +40,7 @@
                   },
                   "signInButton": {
                     "shouldAutotap": false,
+                    "tapOnce": false,
                     "path": "/intro",
                     "selectors": [
                       "a[href*='ServiceLogin']:not([target='_top'])",

injected/src/features/autofill-password-import.js

@@ -23,6 +23,7 @@ export const DELAY_BEFORE_ANIMATION = 300;
  * @property {ButtonAnimationStyle} animationStyle
  * @property {boolean} shouldTap
  * @property {boolean} shouldWatchForRemoval
+ * @property {boolean} tapOnce
  */
 
 /**
@@ -50,6 +51,9 @@ export default class AutofillPasswordImport extends ContentFeature {
 
     #domLoaded;
 
+    /** @type {Set<string>} */
+    #animatedPaths = new Set();
+
     /**
      * @returns {ButtonAnimationStyle}
      */
@@ -136,31 +140,34 @@ export default class AutofillPasswordImport extends ContentFeature {
             const element = await this.findSettingsElement();
             return element != null
                 ? {
-                      animationStyle: this.settingsButtonAnimationStyle,
-                      element,
-                      shouldTap: this.#settingsButtonSettings?.shouldAutotap ?? false,
-                      shouldWatchForRemoval: false,
-                  }
+                    animationStyle: this.settingsButtonAnimationStyle,
+                    element,
+                    shouldTap: this.#settingsButtonSettings?.shouldAutotap ?? false,
+                    shouldWatchForRemoval: false,
+                    tapOnce: false,
+                }
                 : null;
         } else if (path === '/options') {
             const element = await this.findExportElement();
             return element != null
                 ? {
-                      animationStyle: this.exportButtonAnimationStyle,
-                      element,
-                      shouldTap: this.#exportButtonSettings?.shouldAutotap ?? false,
-                      shouldWatchForRemoval: true,
-                  }
+                    animationStyle: this.exportButtonAnimationStyle,
+                    element,
+                    shouldTap: this.#exportButtonSettings?.shouldAutotap ?? false,
+                    shouldWatchForRemoval: true,
+                    tapOnce: true,
+                }
                 : null;
         } else if (path === '/intro') {
             const element = await this.findSignInButton();
             return element != null
                 ? {
-                      animationStyle: this.signInButtonAnimationStyle,
-                      element,
-                      shouldTap: this.#signInButtonSettings?.shouldAutotap ?? false,
-                      shouldWatchForRemoval: false,
-                  }
+                    animationStyle: this.signInButtonAnimationStyle,
+                    element,
+                    shouldTap: this.#signInButtonSettings?.shouldAutotap ?? false,
+                    shouldWatchForRemoval: false,
+                    tapOnce: false,
+                }
                 : null;
         } else {
             return null;
@@ -398,7 +405,12 @@ export default class AutofillPasswordImport extends ContentFeature {
         if (this.isSupportedPath(path)) {
             try {
                 this.setCurrentElementConfig(await this.getElementAndStyleFromPath(path));
-                await this.animateOrTapElement();
+                if (!this.#animatedPaths.has(path)) {
+                    await this.animateOrTapElement();
+                    if (this.currentElementConfig?.shouldTap && this.currentElementConfig?.tapOnce) {
+                        this.#animatedPaths.add(path);
+                    }
+                }
             } catch {
                 console.error('password-import: failed for path:', path);
             }