Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 544bcb2

Browse files
Make title bar opaque when in full screen mode without tabs (#3860)
Task/Issue URL: https://app.asana.com/0/1204006570077678/1209339803211451 Tech Design URL: CC: **Description**: Make title bar opaque when in full screen mode without tabs | Before | After | | ------ | ----- | ![before](https://github.com/user-attachments/assets/1eaaf268-2c42-43d0-b04c-cc88a38a375b)|![after](https://github.com/user-attachments/assets/f4e9289a-68b9-4df8-bcfa-be8e404ffd15) **Steps to test this PR**: 1. Open the browser and open Asana 2. Go to the View menu and deselect `Show Tabs and Bookmarks Bar in Full screen` 3. Enter full screen mode 4. Hover over the top 5. The title bar should be opaque **Definition of Done**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? — ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
1 parent edf7339 commit 544bcb2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

DuckDuckGo/MainWindow/MainWindowController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ extension MainWindowController: NSWindowDelegate {
279279
self?.mainViewController.mainView.webContainerTopConstraintToNavigation.animator().priority = .defaultHigh
280280
self?.mainViewController.mainView.webContainerTopConstraint.animator().priority = .defaultLow
281281
self?.moveTabBarView(toTitlebarView: false)
282+
self?.window?.titlebarAppearsTransparent = false
282283
self?.window?.toolbar = nil
283284
}
284285
}
@@ -290,6 +291,7 @@ extension MainWindowController: NSWindowDelegate {
290291
self?.mainViewController.mainView.navigationBarTopConstraint.animator().constant = 38
291292
self?.mainViewController.mainView.webContainerTopConstraintToNavigation.animator().priority = .defaultLow
292293
self?.mainViewController.mainView.webContainerTopConstraint.animator().priority = .defaultHigh
294+
self?.window?.titlebarAppearsTransparent = true
293295
self?.setupToolbar()
294296
}
295297
}

0 commit comments

Comments
 (0)