DuckPlayer: Open "Watch in Youtube" links in a new tab (#3840)

afterxleep · web-flow · commit 6000c0d9930c · 2025-02-11T19:10:14.000+01:00
Task/Issue URL: https://app.asana.com/0/1204099484721401/1209211829036067 Tech Design URL: CC
diff --git a/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift b/DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift
@@ -311,8 +311,9 @@ extension DuckPlayerTabExtension: NavigationResponder {
             return .next
         }
 
-        if shouldOpenInNewTab, shouldOpenDuckPlayerDirectly,
+        if shouldOpenDuckPlayerDirectly,
            let url = webView?.url, !url.isEmpty, !url.isYoutubeVideo {
+            webView?.stopAllMediaPlayback()
             webView?.loadInNewWindow(navigationAction.url)
             return .cancel
         }

Original file line number	Diff line number	Diff line change
`@@ -311,8 +311,9 @@ extension DuckPlayerTabExtension: NavigationResponder {`
`311`	`311`	`return .next`
`312`	`312`	`}`
`313`	`313`
`314`		`- if shouldOpenInNewTab, shouldOpenDuckPlayerDirectly,`
	`314`	`+ if shouldOpenDuckPlayerDirectly,`
`315`	`315`	`let url = webView?.url, !url.isEmpty, !url.isYoutubeVideo {`
	`316`	`+ webView?.stopAllMediaPlayback()`
`316`	`317`	`webView?.loadInNewWindow(navigationAction.url)`
`317`	`318`	`return .cancel`
`318`	`319`	`}`