Default to expanded favorites NTP section if setting is not present (#3858)

ayoy · web-flow · commit 6618716fd892 · 2025-02-11T08:50:58.000+01:00
Task/Issue URL: https://app.asana.com/0/1201048563534612/1209373805889971 Description: This change ensures that if a user never updated NTP favorites expanded state setting, they will see expanded favorites on NTP.
diff --git a/DuckDuckGo/NewTabPage/NewTabPageActionsManagerExtension.swift b/DuckDuckGo/NewTabPage/NewTabPageActionsManagerExtension.swift
@@ -38,7 +38,7 @@ extension NewTabPageActionsManager {
         let favoritesModel = NewTabPageFavoritesModel(
             actionsHandler: DefaultFavoritesActionsHandler(),
             favoritesPublisher: favoritesPublisher,
-            getLegacyIsViewExpandedSetting: UserDefaultsWrapper<Bool>(key: .homePageShowAllFavorites, defaultValue: false).wrappedValue
+            getLegacyIsViewExpandedSetting: UserDefaultsWrapper<Bool>(key: .homePageShowAllFavorites, defaultValue: true).wrappedValue
         )
 
         let customizationProvider = NewTabPageCustomizationProvider(homePageSettingsModel: settingsModel)

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ extension NewTabPageActionsManager {`
`38`	`38`	`let favoritesModel = NewTabPageFavoritesModel(`
`39`	`39`	`actionsHandler: DefaultFavoritesActionsHandler(),`
`40`	`40`	`favoritesPublisher: favoritesPublisher,`
`41`		`- getLegacyIsViewExpandedSetting: UserDefaultsWrapper<Bool>(key: .homePageShowAllFavorites, defaultValue: false).wrappedValue`
	`41`	`+ getLegacyIsViewExpandedSetting: UserDefaultsWrapper<Bool>(key: .homePageShowAllFavorites, defaultValue: true).wrappedValue`
`42`	`42`	`)`
`43`	`43`
`44`	`44`	`let customizationProvider = NewTabPageCustomizationProvider(homePageSettingsModel: settingsModel)`