Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit ab05170

Browse files
THISISDINOSAURaataraxiaa
THISISDINOSAUR
and
aataraxiaa
authored
Add new empty PIR package to aid migration (#3835)
Task/Issue URL: https://app.asana.com/0/1187352151074490/1209334604294772 Tech Design URL: CC: **Description**: Adds an empty and inert package for now to aid migration. See TD for details **Optional E2E tests**: - [x] Run PIR E2E tests Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this. **Steps to test this PR**: 1. Test macOS still compiles and runs <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --------- Co-authored-by: Pete Smith <[email protected]>
1 parent 012d106 commit ab05170

File tree

9 files changed

+197
-0
lines changed

9 files changed

+197
-0
lines changed

‎DuckDuckGo-macOS.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4469,6 +4469,7 @@
44694469
9D84E3F42CD4E6660046CD8B /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
44704470
9D84E43C2CD4E66F0046CD8B /* DBPE2ETests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = DBPE2ETests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
44714471
9D8FA00B2AC5BDCE005DD0D0 /* LoginItem+DataBrokerProtection.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "LoginItem+DataBrokerProtection.swift"; sourceTree = "<group>"; };
4472+
9D9150F32D53F1F1005B5833 /* DataBrokerProtectionShared */ = {isa = PBXFileReference; lastKnownFileType = wrapper; path = DataBrokerProtectionShared; sourceTree = "<group>"; };
44724473
9D9AE8682AA76CDC0026E7DC /* LoginItem+NetworkProtection.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "LoginItem+NetworkProtection.swift"; sourceTree = "<group>"; };
44734474
9D9AE86A2AA76CF90026E7DC /* LoginItemsManager.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LoginItemsManager.swift; sourceTree = "<group>"; };
44744475
9D9AE8D12AAA39A70026E7DC /* DuckDuckGo Personal Information Removal.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = "DuckDuckGo Personal Information Removal.app"; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -6220,6 +6221,7 @@
62206221
9D9DE5712C63A96400D20B15 /* AppKitExtensions */,
62216222
7B9167A82C09E88800322310 /* AppLauncher */,
62226223
378E279D2970217400FCADA2 /* BuildToolPlugins */,
6224+
9D9150F32D53F1F1005B5833 /* DataBrokerProtectionShared */,
62236225
3192A2702A4C4E330084EA89 /* DataBrokerProtection */,
62246226
7B8FDD1E2CDD877000720907 /* FeatureFlags */,
62256227
9DF2DB592C73B52F0025F43C /* Freemium */,

‎LocalPackages/DataBrokerProtection/Package.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ let package = Package(
3030
],
3131
dependencies: [
3232
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "236.0.0"),
33+
.package(path: "../DataBrokerProtectionShared"),
3334
.package(path: "../SwiftUIExtensions"),
3435
.package(path: "../AppKitExtensions"),
3536
.package(path: "../XPCHelper"),
@@ -40,6 +41,7 @@ let package = Package(
4041
name: "DataBrokerProtection",
4142
dependencies: [
4243
.product(name: "BrowserServicesKit", package: "BrowserServicesKit"),
44+
.product(name: "DataBrokerProtectionShared", package: "DataBrokerProtectionShared"),
4345
.product(name: "SwiftUIExtensions", package: "SwiftUIExtensions"),
4446
.product(name: "AppKitExtensions", package: "AppKitExtensions"),
4547
.byName(name: "XPCHelper"),

‎LocalPackages/DataBrokerProtectionShared/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎LocalPackages/DataBrokerProtectionShared/.swiftpm/xcode/package.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
3+
<plist version="1.0">
4+
<dict>
5+
<key>IDEDidComputeMac32BitWarning</key>
6+
<true/>
7+
</dict>
8+
</plist>

‎LocalPackages/DataBrokerProtectionShared/.swiftpm/xcode/xcshareddata/xcschemes/macOS PIR Tests.xcscheme

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<Scheme
3+
LastUpgradeVersion = "1520"
4+
version = "1.7">
5+
<BuildAction
6+
parallelizeBuildables = "YES"
7+
buildImplicitDependencies = "YES">
8+
</BuildAction>
9+
<TestAction
10+
buildConfiguration = "Debug"
11+
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
12+
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
13+
shouldUseLaunchSchemeArgsEnv = "YES"
14+
shouldAutocreateTestPlan = "YES">
15+
<Testables>
16+
<TestableReference
17+
skipped = "NO">
18+
<BuildableReference
19+
BuildableIdentifier = "primary"
20+
BlueprintIdentifier = "DataBrokerProtectionTests"
21+
BuildableName = "DataBrokerProtectionTests"
22+
BlueprintName = "DataBrokerProtectionTests"
23+
ReferencedContainer = "container:">
24+
</BuildableReference>
25+
</TestableReference>
26+
</Testables>
27+
</TestAction>
28+
<LaunchAction
29+
buildConfiguration = "Debug"
30+
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
31+
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
32+
launchStyle = "0"
33+
useCustomWorkingDirectory = "NO"
34+
ignoresPersistentStateOnLaunch = "NO"
35+
debugDocumentVersioning = "YES"
36+
debugServiceExtension = "internal"
37+
allowLocationSimulation = "YES">
38+
</LaunchAction>
39+
<ProfileAction
40+
buildConfiguration = "Release"
41+
shouldUseLaunchSchemeArgsEnv = "YES"
42+
savedToolIdentifier = ""
43+
useCustomWorkingDirectory = "NO"
44+
debugDocumentVersioning = "YES">
45+
</ProfileAction>
46+
<AnalyzeAction
47+
buildConfiguration = "Debug">
48+
</AnalyzeAction>
49+
<ArchiveAction
50+
buildConfiguration = "Release"
51+
revealArchiveInOrganizer = "YES">
52+
</ArchiveAction>
53+
</Scheme>

‎LocalPackages/DataBrokerProtectionShared/Package.swift

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
// swift-tools-version: 5.7
2+
// The swift-tools-version declares the minimum version of Swift required to build this package.
3+
//
4+
// Package.swift
5+
//
6+
// Copyright © 2025 DuckDuckGo. All rights reserved.
7+
//
8+
// Licensed under the Apache License, Version 2.0 (the "License");
9+
// you may not use this file except in compliance with the License.
10+
// You may obtain a copy of the License at
11+
//
12+
// http://www.apache.org/licenses/LICENSE-2.0
13+
//
14+
// Unless required by applicable law or agreed to in writing, software
15+
// distributed under the License is distributed on an "AS IS" BASIS,
16+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17+
// See the License for the specific language governing permissions and
18+
// limitations under the License.
19+
//
20+
21+
import PackageDescription
22+
23+
let package = Package(
24+
name: "DataBrokerProtectionShared",
25+
platforms: [ .macOS("11.4") ],
26+
products: [
27+
.library(
28+
name: "DataBrokerProtectionShared",
29+
targets: ["DataBrokerProtectionShared"])
30+
],
31+
dependencies: [
32+
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "236.0.0"),
33+
.package(path: "../SwiftUIExtensions"),
34+
.package(path: "../AppKitExtensions"),
35+
.package(path: "../XPCHelper"),
36+
.package(path: "../Freemium"),
37+
],
38+
targets: [
39+
.target(
40+
name: "DataBrokerProtectionShared",
41+
dependencies: [
42+
.product(name: "BrowserServicesKit", package: "BrowserServicesKit"),
43+
.product(name: "SwiftUIExtensions", package: "SwiftUIExtensions"),
44+
.product(name: "AppKitExtensions", package: "AppKitExtensions"),
45+
.byName(name: "XPCHelper"),
46+
.product(name: "PixelKit", package: "BrowserServicesKit"),
47+
.product(name: "Configuration", package: "BrowserServicesKit"),
48+
.product(name: "Persistence", package: "BrowserServicesKit"),
49+
.product(name: "Freemium", package: "Freemium"),
50+
],
51+
resources: [.copy("Resources")],
52+
swiftSettings: [
53+
.define("DEBUG", .when(configuration: .debug))
54+
]
55+
),
56+
.testTarget(
57+
name: "DataBrokerProtectionSharedTests",
58+
dependencies: [
59+
"DataBrokerProtectionShared",
60+
"BrowserServicesKit",
61+
"Freemium",
62+
.product(name: "PersistenceTestingUtils", package: "BrowserServicesKit"),
63+
.product(name: "SubscriptionTestingUtilities", package: "BrowserServicesKit"),
64+
],
65+
resources: [
66+
.copy("Resources")
67+
]
68+
)
69+
]
70+
)

‎LocalPackages/DataBrokerProtectionShared/Sources/DataBrokerProtectionShared/DataBrokerProtectionBlank.swift

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
//
2+
// DataBrokerProtectionBlank.swift
3+
//
4+
// Copyright © 2025 DuckDuckGo. All rights reserved.
5+
//
6+
// Licensed under the Apache License, Version 2.0 (the "License");
7+
// you may not use this file except in compliance with the License.
8+
// You may obtain a copy of the License at
9+
//
10+
// http://www.apache.org/licenses/LICENSE-2.0
11+
//
12+
// Unless required by applicable law or agreed to in writing, software
13+
// distributed under the License is distributed on an "AS IS" BASIS,
14+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15+
// See the License for the specific language governing permissions and
16+
// limitations under the License.
17+
//
18+
19+
import Foundation

‎LocalPackages/DataBrokerProtectionShared/Tests/.swiftlint.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
disabled_rules:
2+
- file_length
3+
- unused_closure_parameter
4+
- type_name
5+
- force_cast
6+
- force_try
7+
- function_body_length
8+
- cyclomatic_complexity
9+
- identifier_name
10+
- blanket_disable_command
11+
- type_body_length
12+
- explicit_non_final_class
13+
- enforce_os_log_wrapper
14+
15+
large_tuple:
16+
warning: 6
17+
error: 10

‎LocalPackages/DataBrokerProtectionShared/Tests/DataBrokerProtectionSharedTests/DataBrokerProtectionBlankTests.swift

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
//
2+
// DataBrokerProtectionBlankTests.swift
3+
//
4+
// Copyright © 2025 DuckDuckGo. All rights reserved.
5+
//
6+
// Licensed under the Apache License, Version 2.0 (the "License");
7+
// you may not use this file except in compliance with the License.
8+
// You may obtain a copy of the License at
9+
//
10+
// http://www.apache.org/licenses/LICENSE-2.0
11+
//
12+
// Unless required by applicable law or agreed to in writing, software
13+
// distributed under the License is distributed on an "AS IS" BASIS,
14+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15+
// See the License for the specific language governing permissions and
16+
// limitations under the License.
17+
//
18+
19+
import Foundation

0 commit comments

Comments
 (0)