Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests in tracer_test module #1

Open
duncanatt opened this issue Nov 12, 2021 · 0 comments
Open

Update tests in tracer_test module #1

duncanatt opened this issue Nov 12, 2021 · 0 comments
Labels
bug Something isn't working test

Comments

@duncanatt
Copy link
Owner

The unit tests in the tracer_test module are time-dependent, which is not the best way to test concurrent code.
The use of timing was done in an effort to affect the trace event routing algorithm as least as possible: we cannot synchronise with it via message passing to influence the different interleaved execution of the offline tracer (responsible only for managing the interleaving of system process trace events) and the trace event routing algorithm (responsible for forwarding events to the correct tracer), which is, itself, concurrent.

The general problem with these types of tests is that assertions are too fine-grained, and attempt to check every step in the execution, rather than focusing on the final monitored system configuration.
These assertions must, therefore, be rewritten to check the monitored system internal state and resulting configuration in a coarser manner.
The suspicion is that this must be done, once, at the end of each test run.

It is due to this reason that presently, tracer_test will not be executed in the build pipeline; this will be reverted once the module and tests within are fixed.

@duncanatt duncanatt added bug Something isn't working help wanted Extra attention is needed test and removed help wanted Extra attention is needed labels Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test
Projects
None yet
Development

No branches or pull requests

1 participant