Skip to content
This repository was archived by the owner on May 5, 2022. It is now read-only.

TrinoDialect should set if it supports statement cache #44

Open
mbacovsky opened this issue Jan 26, 2022 · 0 comments
Open

TrinoDialect should set if it supports statement cache #44

mbacovsky opened this issue Jan 26, 2022 · 0 comments

Comments

@mbacovsky
Copy link

Hello,

Since SQLAlchemy 1.4.5 it is required from third party dialects to set whether they comply with statement cache with supports_statement_cache attribute. More details in the docs.

If the attribute is not set the warnings like

lib/python3.8/site-packages/sqlalchemy_trino/dialect.py:259: SAWarning: Dialect trino:rest will not make use of SQL compilation caching as it does not set the 'supports_statement_cache' attribute to ``True``. 
This can have significant performance implications including some performance degradations in comparison to prior SQLAlchemy versions.  
Dialect maintainers should seek to set this attribute to True after appropriate development and testing for SQLAlchemy 1.4 caching support.  
Alternatively, this attribute may be set to False which will disable this warning. (Background on this error at: https://sqlalche.me/e/14/cprf)

are raised.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant