Skip to content

Commit ce36ecb

Browse files
billytrendrvagg
authored andcommitted
Removes buffer-equal-constant-time dependency
1 parent 3b1e329 commit ce36ecb

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

github-webhook-handler.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ const EventEmitter = require('events').EventEmitter
22
, inherits = require('util').inherits
33
, crypto = require('crypto')
44
, bl = require('bl')
5-
, bufferEq = require('buffer-equal-constant-time')
65

76
function create (options) {
87
if (typeof options != 'object')
@@ -37,7 +36,7 @@ function create (options) {
3736
}
3837

3938
function verify (signature, data) {
40-
return bufferEq(Buffer.from(signature), Buffer.from(sign(data)))
39+
return crypto.timingSafeEqual(Buffer.from(signature), Buffer.from(sign(data)))
4140
}
4241

4342
function handler (req, res, callback) {

package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
},
1919
"license": "MIT",
2020
"dependencies": {
21-
"bl": "~1.1.2",
22-
"buffer-equal-constant-time": "~1.0.1"
21+
"bl": "~1.1.2"
2322
},
2423
"devDependencies": {
2524
"@types/node": "*",

0 commit comments

Comments
 (0)