Skip to content

Commit c4fff38

Browse files
committed
fixed WebMock calls
1 parent 828160f commit c4fff38

File tree

3 files changed

+16
-20
lines changed

3 files changed

+16
-20
lines changed

Rakefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Bundler::GemHelper.install_tasks
55

66
require 'rake/testtask'
77
Rake::TestTask.new(:test) do |test|
8-
test.libs << 'lib' << 'test'
8+
test.libs << 'lib' << 'spec'
99
test.pattern = 'spec/*.rb'
1010
test.verbose = true
1111
end

spec/statement_spec.rb

+12-16
Original file line numberDiff line numberDiff line change
@@ -6,62 +6,58 @@
66
describe Statement do
77
it "parses an rss feed" do
88
@feed_url = "http://ruiz.house.gov/rss.xml"
9-
stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "ruiz_rss.xml")), :status => 200)
9+
WebMock.stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "ruiz_rss.xml")), :status => 200)
1010
@results = Feed.from_rss(@feed_url)
1111
@results.first[:domain].must_equal "ruiz.house.gov"
1212
end
1313

1414
it "parses House GOP press release page" do
1515
@feed_url = "http://www.gop.gov/republicans/news?offset=03/29/13"
16-
stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "house_gop_releases.html")), :status => 200)
16+
WebMock.stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "house_gop_releases.html")), :status => 200)
1717
@results = Scraper.house_gop(@feed_url)
1818
@results.first[:source].must_equal @feed_url
1919
end
2020

2121
it "does not attempt to parse dates when none are present" do
2222
@feed_url = "http://culberson.house.gov/feed/rss/"
23-
stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "culberson_rss.xml")), :status => 200)
23+
WebMock.stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "culberson_rss.xml")), :status => 200)
2424
@results = Feed.from_rss(@feed_url)
2525
@results.first[:date].must_equal nil
2626
end
2727

2828
it "parses invalid RSS" do
2929
@feed_url = "http://www.burr.senate.gov/public/index.cfm?FuseAction=RSS.Feed"
30-
stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "richard_burr.xml")), :status => 200)
30+
WebMock.stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "richard_burr.xml")), :status => 200)
3131
@results = Feed.from_rss(@feed_url)
3232
@results.first[:url].must_equal "http://www.burr.senate.gov/public/index.cfm?FuseAction=PressOffice.PressReleases&Type=Press Release&ContentRecord_id=65dbea38-d64c-6208-ef8f-2b000e899b3a"
3333
@results.first[:date].to_s.must_equal "2013-05-02"
3434
end
3535

3636
it "handles relative URLs" do
3737
@feed_url = "http://www.gop.gov/republicans/news?offset=03/29/13"
38-
stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "house_gop_releases.html")), :status => 200)
38+
WebMock.stub_request(:any, @feed_url).to_return(:body => File.new(File.join(File.dirname(__FILE__), "house_gop_releases.html")), :status => 200)
3939
@results = Scraper.house_gop(@feed_url)
4040
@results.last[:url].must_equal "http://www.gop.gov/republicans/other/relative_url_test.html"
4141
end
4242

4343
it "scrapes a senate cold fusion page" do
4444
@url = "http://www.billnelson.senate.gov/news/media.cfm?year=2013"
45-
stub_request(:any, @url).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'bill_nelson_press.html')), :status => 200)
45+
WebMock.stub_request(:any, @url).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'bill_nelson_press.html')), :status => 200)
4646
@results = Scraper.billnelson(year=2013)
4747
@results.last[:url].must_equal "http://www.billnelson.senate.gov/news/details.cfm?id=338190&"
4848
end
4949

50-
it "scrapes vitter and cowan pages for 2013" do
50+
it "scrapes vitter pages for 2013" do
5151
@vitter = "http://www.vitter.senate.gov/newsroom/press?year=2013"
52-
@cowan = "http://www.cowan.senate.gov/press?year=2013"
53-
stub_request(:any, @vitter).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'vitter_press.html')), :status => 200)
54-
stub_request(:any, @cowan).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'cowan_press.html')), :status => 200)
55-
@results = Scraper.vitter_cowan(year=2013)
56-
@results.map{|r| r[:domain]}.uniq.must_equal ["www.vitter.senate.gov", "www.cowan.senate.gov"]
52+
WebMock.stub_request(:any, @vitter).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'vitter_press.html')), :status => 200)
53+
@results = Scraper.vitter(year=2013)
54+
@results.map{|r| r[:domain]}.uniq.must_equal ["www.vitter.senate.gov"]
5755
end
5856

5957
it "only scrapes vitter page for 2012" do
6058
@vitter = "http://www.vitter.senate.gov/newsroom/press?year=2012"
61-
@cowan = "http://www.cowan.senate.gov/press?year=2012"
62-
stub_request(:any, @vitter).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'vitter_press.html')), :status => 200)
63-
stub_request(:any, @cowan).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'cowan_press.html')), :status => 200)
64-
@results = Scraper.vitter_cowan(year=2012)
59+
WebMock.stub_request(:any, @vitter).to_return(:body => File.new(File.join(File.dirname(__FILE__), 'vitter_press.html')), :status => 200)
60+
@results = Scraper.vitter(year=2012)
6561
@results.map{|r| r[:domain]}.uniq.must_equal ["www.vitter.senate.gov"]
6662
end
6763

statement.gemspec

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ Gem::Specification.new do |spec|
1919
spec.require_paths = ["lib"]
2020

2121
spec.add_development_dependency "bundler", "~> 1.3"
22-
spec.add_development_dependency "rake"
23-
spec.add_development_dependency 'webmock'
24-
spec.add_development_dependency 'minitest'
22+
spec.add_dependency "rake"
23+
spec.add_dependency 'webmock'
24+
spec.add_dependency 'minitest'
2525
spec.add_dependency "american_date"
2626
if RUBY_VERSION > "1.8.7"
2727
spec.add_dependency "nokogiri"

0 commit comments

Comments
 (0)