updated with review comments

Author: dylanowen

js-src/functions/build.sbt

@@ -1,5 +1,3 @@
-import org.scalajs.core.tools.linker.backend.OutputMode
-
 enablePlugins(ScalaJSPlugin)
 
 name := "functions"
@@ -12,7 +10,6 @@ libraryDependencies ++= Seq(
 // move our output folder to static
 artifactPath in(Compile, fastOptJS) := baseDirectory.value / ".." / ".." / "resources" / "js" / s"scala-${name.value}.js"
 artifactPath in(Compile, fullOptJS) := baseDirectory.value / ".." / ".." / "resources" / "js" / s"scala-${name.value}.js"
-scalaJSOptimizerOptions in (Compile, fullOptJS) ~= { _.withUseClosureCompiler(true) }
 
 scalaJSUseMainModuleInitializer := true
-emitSourceMaps := false
+scalaJSLinkerConfig ~= { _.withSourceMap(false) }

js-src/functions/src/main/scala/org/scalalang/DownloadLinks.scala

@@ -2,7 +2,7 @@ package org.scalalang
 
 import org.querki.jquery._
 import org.scalajs.dom.{Element, document}
-import org.scalalang.utils.{JsUtils, Logger, OS}
+import org.scalalang.utils.{JsUtils, OS}
 
 /**
   * This updates our download links based on the OS of the client

js-src/functions/src/main/scala/org/scalalang/FunctionsApp.scala

@@ -2,19 +2,14 @@ package org.scalalang
 
 import org.querki.jquery._
 import org.scalajs.dom.document
-import org.scalalang.utils.{Logger, RootLogger}
 
 /**
   * This is the main entry point for our application
   */
 object FunctionsApp {
-  RootLogger.setInfo()
-
-  private val logger: Logger = Logger[FunctionsApp.type]
-
   def main(args: Array[String]): Unit = {
     $(document).ready(() => {
-      logger.trace("Dom Ready")
+      println("Dom Ready")
 
       Tooltip()
       DownloadLinks()

js-src/functions/src/main/scala/org/scalalang/utils/Logger.scala

@@ -5,50 +5,27 @@ import org.scalajs.dom.window
 /**
   * Find which OS our client is running
   */
-sealed trait OS {
-  val navigator: String
-  val label: String
-}
+sealed abstract class OS(val navigator: String, val label: String)
 
 object OS {
 
-  private val logger: Logger = Logger[OS.type]
+  case object Windows extends OS("Win", "windows")
 
-  case object Windows extends OS {
-    override val navigator: String = "Win"
-    override val label: String = "windows"
-  }
-
-  case object Mac extends OS {
-    override val navigator: String = "Mac"
-    override val label: String = "osx"
-  }
+  case object Mac extends OS("Mac", "osx")
 
-  case object Linux extends OS {
-    override val navigator: String = "Linux"
-    override val label: String = "linux"
-  }
+  case object Linux extends OS("Linux", "linux")
 
-  case object Unix extends OS {
-    override val navigator: String = "X11"
-    override val label: String = "unix"
-  }
+  case object Unix extends OS("X11", "unix")
 
   def apply(): OS = {
     val appVersion: String = window.navigator.appVersion
     val default: OS = Linux
 
     val os: OS = Array(Windows, Mac, Linux, Unix)
-      .foldLeft(default)((last: OS, os: OS) => {
-        if (appVersion.contains(os.navigator)) {
-          os
-        }
-        else {
-          last
-        }
-      })
-
-    logger.trace("OS: " + os)
+      .find(os => appVersion.contains(os.navigator))
+      .getOrElse(default)
+
+    println("OS: " + os)
 
     os
   }