Merge pull request #2 from dynatrace-api-framework/PAF-16_Verify_SSL_Option

PAF-16 Verify SSL option

Author: Philipose

Pipfile

@@ -0,0 +1,13 @@
+[[source]]
+name = "pypi"
+url = "https://pypi.org/simple"
+verify_ssl = true
+
+[dev-packages]
+pylint = "*"
+
+[packages]
+requests = "*"
+
+[requires]
+python_version = "3.4"

Pipfile.lock

@@ -1,6 +1,6 @@
 # Dynatrace Python3 API Framework
 
-Testing the Dev Branch
+Testing the "Test" Branch
 
 **Python Requirements**:
 Requests
@@ -12,4 +12,4 @@ Python >= 3.4 (Built and tested with Python 3.8)
 1. Create user variable file in ./variable_sets in the format of template provided
 2. Run python change_variables.py and type in the name of the file (without ".py").
     It will copy over the new file as user_variables.py
-3. Create "sandbox_script.py" for trying out script or create your scripts in ./scripts
+3. Create "sandbox_script.py" for trying out script or create your scripts in ./scripts

README.md

@@ -7,7 +7,7 @@ def replace_env():
   print("Enter Set to Import: ", end='')
   new_env = input()
 
-  if "win" in sys.platform:
+  if "windows" in sys.platform:
     os.system("copy variable_sets\\" + str(new_env) + ".py user_variables.py")
   else:
     os.system("cp variable_sets/" + str(new_env) + ".py user_variables.py")

change_variables.py

@@ -18,7 +18,6 @@ def merge_environment_settings(self, url, proxies, stream, verify, cert):
     opened_adapters.add(self.get_adapter(url))
 
     settings = OLD_MERGE_ENVIRONMENT_SETTINGS(self, url, proxies, stream, verify, cert)
-    settings['verify'] = False
 
     return settings
 
@@ -74,11 +73,11 @@ def cluster_get(cluster, endpoint, params=None):
 
   with no_ssl_verification():
     params['Api-Token'] = cluster['cluster_token']
-
+    
     response = requests.get(
         "https://" + cluster['url'] + "/api/v1.0/onpremise/" + endpoint,
         params=params,
-        verify=False
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"])
     )
     check_response(response)
     return response
@@ -100,7 +99,7 @@ def cluster_post(cluster, endpoint, params=None, json=None):
         "https://" + cluster['url'] + "/api/v1.0/onpremise/" + endpoint,
         params=params,
         json=json,
-        verify=False
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"])
     )
     check_response(response)
     return response
@@ -121,7 +120,7 @@ def cluster_put(cluster, endpoint, params=None, json=None):
         "https://" + cluster['url'] + "/api/v1.0/onpremise/" + endpoint,
         params=params,
         json=json,
-        verify=False
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"])
     )
     check_response(response)
     return response
@@ -141,7 +140,7 @@ def cluster_delete(cluster, endpoint, params=None, json=None):
         "https://" + cluster['url'] + "/api/v1.0/onpremise/" + endpoint,
         params=params,
         json=json,
-        verify=False
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"])
     )
     check_response(response)
     return response
@@ -158,7 +157,7 @@ def env_get(cluster, tenant, endpoint, params=None):
     response = requests.get(
         generate_tenant_url(cluster, tenant) + "/api/v1/" + endpoint,
         params=params,
-        verify=False
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"])
     )
     check_response(response)
     return response
@@ -176,7 +175,7 @@ def env_post(cluster, tenant, endpoint, params=None, json=None):
     response = requests.post(
         generate_tenant_url(cluster, tenant) + "/api/v1/" + endpoint,
         params=params,
-        verify=False,
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"]),
         json=json
     )
     check_response(response)
@@ -195,7 +194,7 @@ def env_put(cluster, tenant, endpoint, params=None, json=None):
     response = requests.put(
         generate_tenant_url(cluster, tenant) + "/api/v1/" + endpoint,
         params=params,
-        verify=False,
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"]),
         json=json
     )
     check_response(response)
@@ -213,7 +212,7 @@ def env_delete(cluster, tenant, endpoint, params=None):
     response = requests.delete(
         generate_tenant_url(cluster, tenant) + "/api/v1/" + endpoint,
         params=params,
-        verify=False
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"])
     )
     check_response(response)
     return response
@@ -232,7 +231,7 @@ def config_get(cluster, tenant, endpoint, params=None, json=None):
     response = requests.get(
         generate_tenant_url(cluster, tenant) + "/api/config/v1/" + endpoint,
         params=params,
-        verify=False,
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"]),
         json=json
     )
     check_response(response)
@@ -251,7 +250,7 @@ def config_post(cluster, tenant, endpoint, params=None, json=None):
     response = requests.post(
         generate_tenant_url(cluster, tenant) + "/api/config/v1/" + endpoint,
         params=params,
-        verify=False,
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"]),
         json=json
     )
     check_response(response)
@@ -270,7 +269,7 @@ def config_put(cluster, tenant, endpoint, params=None, json=None):
     response = requests.put(
         generate_tenant_url(cluster, tenant) + "/api/config/v1/" + endpoint,
         params=params,
-        verify=False,
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"]),
         json=json
     )
     check_response(response)
@@ -289,7 +288,7 @@ def config_delete(cluster, tenant, endpoint, params=None, json=None):
     response = requests.delete(
         generate_tenant_url(cluster, tenant) + "/api/config/v1/" + endpoint,
         params=params,
-        verify=False,
+        verify=(True if "verify_ssl" not in cluster else cluster ["verify_ssl"]),
         json=json
     )
     check_response(response)

dynatrace/requests/request_handler.py

@@ -11,6 +11,7 @@
             "tenant2": "API TOKEN GOES HERE",
         },
         "is_managed": True,
+        "verify_ssl": True,
         "cluster_token": "Required for Cluster Operations in Managed"
     }
 }