Converted global variable to static class #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added result validator to better emulate original behaviour. Harmonized the internals of the calls. Added my name to authors and incremented version number
Contributor
|
Good changes in the PR, I will see how this can be merged with the current version in master |
bastianleicht
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global $link was a little generic, and I'd be worried it would be overwritten in a sprawling codebase. Converted it (and the global_link_identifier) function to a static class property/function.
The mysqli_result type hinting was causing fatal errors. Removed the type hint and added a "result validator" to return bool true/false (with a warning). To better emulate the original behaviour.