Reports should use system line separators (#13)

Author: mcumings

src/main/kotlin/com/ebay/plugins/metrics/develocity/GatherAggregateTask.kt

@@ -51,6 +51,7 @@ open class GatherAggregateTask @Inject constructor(
         val inputs = sourceOutputDirectories.files
             .sorted()
             .joinToString(prefix = "Aggregating sources:\n\t", separator = "\n\t") { it.name }
+            .replace("\n", System.lineSeparator())
         outputDirectoryProperty.file("inputs").get().asFile.writeText(inputs)
 
         val summarizerStates = summarizersProperty.get().map { MetricSummarizerState(it) }

src/main/kotlin/com/ebay/plugins/metrics/develocity/GatherHourlyTask.kt

@@ -100,7 +100,7 @@ open class GatherHourlyTask @Inject constructor(
         // Fail task execution if we receive any error responses
         val errorHandler: (response: HttpResponse) -> Unit = {
             runBlocking {
-                throw GradleException("Failed to get builds: ${it.call.response.status}\n\t${it.call.response.bodyAsText()}")
+                throw GradleException("Failed to get builds: ${it.call.response.status}${System.lineSeparator()}\t${it.call.response.bodyAsText()}")
             }
         }
 

src/main/kotlin/com/ebay/plugins/metrics/develocity/projectcost/ProjectCostInspectionTask.kt

@@ -116,7 +116,7 @@ internal abstract class ProjectCostInspectionTask : DefaultTask(), MetricSummari
             append(topTypesByExecutions)
             append(impactedUserReport)
             append(buildScansReport)
-        }
+        }.replace("\n", System.lineSeparator())
         outputFile.asFile.get().also { reportFile ->
             logger.lifecycle("Project cost inspection report available at: file://${reportFile.absolutePath}")
             reportFile.writeText(report)

src/main/kotlin/com/ebay/plugins/metrics/develocity/userquery/UserQueryReportTask.kt

@@ -16,17 +16,14 @@ internal abstract class UserQueryReportTask : DefaultTask(), MetricSummarizerTas
     @get:OutputFile
     abstract val reportFile: RegularFileProperty
 
-    init {
-        group = "graph analytics"
-    }
-
     @TaskAction
     fun createReport() {
         val summaryFile = summarizerDataProperty.get()
         val model = UserQuerySummarizer().read(summaryFile)
         val report = model.users.sorted().joinToString(
             prefix = "User(s) who have performed builds matching the query filter (${model.users.size}):\n    ",
             separator = "\n    ")
+            .replace("\n", System.lineSeparator())
         reportFile.asFile.get().also { reportFile ->
             logger.lifecycle("User report available at: file://${reportFile.absolutePath}")
             reportFile.writeText(report)