Skip to content

Commit 96feb3c

Browse files
committed
Fix conflict
Signed-off-by: Javier Gil Aviles <[email protected]>
1 parent d2c3c07 commit 96feb3c

File tree

2 files changed

+1
-112
lines changed

2 files changed

+1
-112
lines changed

src/cpp/fastdds/domain/DomainParticipantFactory.cpp

Lines changed: 0 additions & 111 deletions
Original file line numberDiff line numberDiff line change
@@ -341,125 +341,14 @@ ReturnCode_t DomainParticipantFactory::get_participant_qos_from_profile(
341341
return RETCODE_BAD_PARAMETER;
342342
}
343343

344-
<<<<<<< HEAD
345-
=======
346-
ReturnCode_t DomainParticipantFactory::get_participant_qos_from_xml(
347-
const std::string& xml,
348-
DomainParticipantQos& qos) const
349-
{
350-
ParticipantAttributes attr;
351-
if (XMLP_ret::XML_OK == XMLProfileManager::fill_participant_attributes_from_xml(xml, attr, false))
352-
{
353-
qos = default_participant_qos_;
354-
utils::set_qos_from_attributes(qos, attr.rtps);
355-
return RETCODE_OK;
356-
}
357-
358-
return RETCODE_BAD_PARAMETER;
359-
}
360-
361-
ReturnCode_t DomainParticipantFactory::get_participant_qos_from_xml(
362-
const std::string& xml,
363-
DomainParticipantQos& qos,
364-
const std::string& profile_name) const
365-
{
366-
if (profile_name.empty())
367-
{
368-
EPROSIMA_LOG_ERROR(DDS_DOMAIN, "Provided profile name must be non-empty");
369-
return RETCODE_BAD_PARAMETER;
370-
}
371-
372-
ParticipantAttributes attr;
373-
if (XMLP_ret::XML_OK == XMLProfileManager::fill_participant_attributes_from_xml(xml, attr, true, profile_name))
374-
{
375-
qos = default_participant_qos_;
376-
utils::set_qos_from_attributes(qos, attr.rtps);
377-
return RETCODE_OK;
378-
}
379-
380-
return RETCODE_BAD_PARAMETER;
381-
}
382-
383-
ReturnCode_t DomainParticipantFactory::get_default_participant_qos_from_xml(
384-
const std::string& xml,
385-
DomainParticipantQos& qos) const
386-
{
387-
ParticipantAttributes attr;
388-
if (XMLP_ret::XML_OK == XMLProfileManager::fill_default_participant_attributes_from_xml(xml, attr, true))
389-
{
390-
qos = default_participant_qos_;
391-
utils::set_qos_from_attributes(qos, attr.rtps);
392-
return RETCODE_OK;
393-
}
394-
395-
return RETCODE_BAD_PARAMETER;
396-
}
397-
398-
>>>>>>> 55cf7b2a (Fix log category name macro collision in `MacOS` (#5585) (#5595))
399344
ReturnCode_t DomainParticipantFactory::get_participant_extended_qos_from_profile(
400345
const std::string& profile_name,
401346
DomainParticipantExtendedQos& extended_qos) const
402347
{
403-
extended_qos = default_participant_qos_;
404348
ParticipantAttributes attr;
405349
if (XMLP_ret::XML_OK == XMLProfileManager::fillParticipantAttributes(profile_name, attr, false))
406-
{
407-
<<<<<<< HEAD
408-
=======
409-
extended_qos = default_participant_qos_;
410-
utils::set_extended_qos_from_attributes(extended_qos, attr);
411-
return RETCODE_OK;
412-
}
413-
414-
return RETCODE_BAD_PARAMETER;
415-
}
416-
417-
ReturnCode_t DomainParticipantFactory::get_participant_extended_qos_from_xml(
418-
const std::string& xml,
419-
DomainParticipantExtendedQos& extended_qos) const
420-
{
421-
ParticipantAttributes attr;
422-
if (XMLP_ret::XML_OK == XMLProfileManager::fill_participant_attributes_from_xml(xml, attr, false))
423-
{
424-
extended_qos = default_participant_qos_;
425-
utils::set_extended_qos_from_attributes(extended_qos, attr);
426-
return RETCODE_OK;
427-
}
428-
429-
return RETCODE_BAD_PARAMETER;
430-
}
431-
432-
ReturnCode_t DomainParticipantFactory::get_participant_extended_qos_from_xml(
433-
const std::string& xml,
434-
DomainParticipantExtendedQos& extended_qos,
435-
const std::string& profile_name) const
436-
{
437-
if (profile_name.empty())
438-
{
439-
EPROSIMA_LOG_ERROR(DDS_DOMAIN, "Provided profile name must be non-empty");
440-
return RETCODE_BAD_PARAMETER;
441-
}
442-
443-
ParticipantAttributes attr;
444-
if (XMLP_ret::XML_OK == XMLProfileManager::fill_participant_attributes_from_xml(xml, attr, true, profile_name))
445-
{
446-
extended_qos = default_participant_qos_;
447-
utils::set_extended_qos_from_attributes(extended_qos, attr);
448-
return RETCODE_OK;
449-
}
450-
451-
return RETCODE_BAD_PARAMETER;
452-
}
453-
454-
ReturnCode_t DomainParticipantFactory::get_default_participant_extended_qos_from_xml(
455-
const std::string& xml,
456-
DomainParticipantExtendedQos& extended_qos) const
457-
{
458-
ParticipantAttributes attr;
459-
if (XMLP_ret::XML_OK == XMLProfileManager::fill_default_participant_attributes_from_xml(xml, attr, true))
460350
{
461351
extended_qos = default_participant_qos_;
462-
>>>>>>> 55cf7b2a (Fix log category name macro collision in `MacOS` (#5585) (#5595))
463352
utils::set_extended_qos_from_attributes(extended_qos, attr);
464353
return RETCODE_OK;
465354
}

test/blackbox/common/DDSBlackboxTestsBasic.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1087,7 +1087,7 @@ TEST(DDSBasic, participant_factory_output_log_error_no_macro_collision)
10871087

10881088
auto dpf = DomainParticipantFactory::get_shared_instance();
10891089
DomainParticipantQos qos;
1090-
dpf->get_participant_qos_from_xml("", qos, "");
1090+
dpf->get_participant_qos_from_profile("", qos);
10911091
Log::Flush();
10921092
ASSERT_GE(n_logs.load(), 1u);
10931093
}

0 commit comments

Comments
 (0)