Update to Rust 1.91

Author: paraseba

.github/workflows/code-quality.yaml

@@ -19,7 +19,7 @@ env:
   RUST_BACKTRACE: short
   RUSTFLAGS: "-D warnings -W unreachable-pub -W bare-trait-objects"
   RUSTUP_MAX_RETRIES: 10
-  RUST_CHANNEL: '1.89.0'
+  RUST_CHANNEL: '1.91.0'
 
 jobs:
   code-quality:

.github/workflows/dependency-check.yaml

@@ -21,7 +21,7 @@ env:
   CI: 1
   RUST_BACKTRACE: short
   RUSTUP_MAX_RETRIES: 10
-  RUST_CHANNEL: '1.89.0'
+  RUST_CHANNEL: '1.91.0'
   CARGO_DENY_VERSION: '0.18.4'
 
 jobs:

.github/workflows/publish-rust-library.yml

@@ -8,7 +8,7 @@ env:
   RUSTFLAGS: "-D warnings -W unreachable-pub -W bare-trait-objects"
   RUSTUP_MAX_RETRIES: 10
   # update RUST_CHANNEL and CARGO_DENY in sync
-  RUST_CHANNEL: '1.89.0'
+  RUST_CHANNEL: '1.91.0'
   CARGO_DENY_VERSION: '0.18.4'
 
 on:

.github/workflows/rust-ci.yaml

@@ -24,7 +24,7 @@ env:
   RUST_BACKTRACE: short
   RUSTFLAGS: "-D warnings -W unreachable-pub -W bare-trait-objects"
   RUSTUP_MAX_RETRIES: 10
-  RUST_CHANNEL: '1.89.0'
+  RUST_CHANNEL: '1.91.0'
 
 jobs:
   rust:

.github/workflows/windows-check.yml

@@ -29,7 +29,7 @@ jobs:
       #pull-requests: read
     env:
       #CC: deny_c
-      RUST_CHANNEL: '1.89.0'
+      RUST_CHANNEL: '1.91.0'
 
 
     steps:

icechunk/src/format/manifest.rs

@@ -205,7 +205,7 @@ impl ManifestSplits {
 pub fn uniform_manifest_split_edges(num_chunks: u32, split_size: &u32) -> Vec<u32> {
     (0u32..=num_chunks)
         .step_by(*split_size as usize)
-        .chain((num_chunks % split_size != 0).then_some(num_chunks))
+        .chain((!num_chunks.is_multiple_of(*split_size)).then_some(num_chunks))
         .collect()
 }
 #[derive(Debug, Error)]

icechunk/src/storage/mod.rs

@@ -1074,7 +1074,7 @@ mod tests {
             // the request sizes add up to total size
             prop_assert_eq!(res.iter().map(|range| range.end - range.start).sum::<u64>(), size);
 
-            let sizes: Vec<_> = res.iter().map(|range| (range.end - range.start)).collect();
+            let sizes: Vec<_> = res.iter().map(|range| range.end - range.start).collect();
             if sizes.len() > 1 {
                 // all but last request have the same size
                 assert_eq!(sizes.iter().rev().skip(1).unique().count(), 1);
@@ -1114,7 +1114,7 @@ mod tests {
             prop_assert_eq!(res.iter().map(|range| range.end - range.start).sum::<u64>(), size);
 
             // there are only two request sizes
-            let sizes: HashSet<_> = res.iter().map(|range| (range.end - range.start)).collect();
+            let sizes: HashSet<_> = res.iter().map(|range| range.end - range.start).collect();
             prop_assert!(sizes.len() <= 2); // only last element is smaller
             if sizes.len() > 1 {
                 // the smaller request size is one less than the big ones