🛠️ Handle invalid charset encoding in XMLRequestExtractor

Author: coreequip

src/main/java/io/github/easybill/xrviz/handler/XmlRequestExtractor.java

@@ -32,8 +32,14 @@ Optional<String> validate(HttpExchange exchange) throws IOException {
         String encoding = detector.getDetectedCharset();
         detector.reset();
 
-        // Fallback to UTF-8 if no encoding was detected
-        Charset charset = (encoding != null) ? Charset.forName(encoding) : StandardCharsets.UTF_8;
+        Charset charset = null;
+        try {
+            charset = (encoding != null) ? Charset.forName(encoding) : StandardCharsets.UTF_8;
+        } catch (IllegalArgumentException e) {
+            logger.severe("Invalid charset: " + encoding);
+            exchange.sendResponseHeaders(HttpURLConnection.HTTP_BAD_REQUEST, -1);
+            return Optional.empty();
+        }
 
         String xml = new String(requestBody, charset);
 

src/test/http/api-test.http

@@ -87,3 +87,10 @@ Content-Type: application/xml
 Accept-Language: de
 
 < ./base-example-utf16le.xml
+
+### Generate a HTML file from a XML with broken encoding
+POST {{baseUrl}}/convert.html
+Content-Type: application/xml
+Accept-Language: de
+
+< ./broken-encoding.xml