Skip to content

Commit 0c0bdbf

Browse files
committed
Added J1939 to Extended dbc and vice versa
1 parent 640453b commit 0c0bdbf

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

src/canmatrix/cli/convert.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ def get_formats():
9090
@click.option('--checkFloatingSignals/--no-checkFloatingSignals', 'checkFloatingSignals', default = False, help="if checkFloatingSignals is set, then unassigned signals to a frame/message will be warned \tdefault: False")
9191

9292

93+
9394
# arxml switches
9495
@click.option('--arxmlIgnoreClusterInfo/--no-arxmlIgnoreClusterInfo', 'arxmlIgnoreClusterInfo', default=False, help="Ignore any can cluster info from arxml; Import all frames in one matrix\ndefault False")
9596
@click.option('--arxmlExportVersion', 'arVersion', default="3.2.3", help="Set output AUTOSAR version\ncurrently only 3.2.3 and 4.1.0 are supported\ndefault 3.2.3")
@@ -103,6 +104,9 @@ def get_formats():
103104
@click.option('--dbcExportEncoding', 'dbcExportEncoding', default="iso-8859-1", help="Export charset of dbc (relevant for units), maybe utf-8\ndefault iso-8859-1")
104105
@click.option('--dbcExportCommentEncoding', 'dbcExportCommentEncoding', default="iso-8859-1", help="Export charset of comments in dbc\ndefault iso-8859-1")
105106
@click.option('--dbcUniqueSignalNames/--no-dbcUniqueSignalNames', 'dbcUniqueSignalNames', default=True, help="Check if signal names are unique per frame")
107+
@click.option('--convertToExtended/--no-convertToExtended', 'convertToExtended', default = False, help="if convertToExtended is set , then the canmatrix will convert the dbc to extended format \tdefault: False")
108+
@click.option('--convertToJ1939/--no-convertToJ1939', 'convertToJ1939', default = False, help="if convertToJ1939 is set , then the canmatrix will convert the dbc to J1939 format \tdefault: False")
109+
106110
# dbf switches
107111
@click.option('--dbfImportEncoding', 'dbfImportEncoding', default="iso-8859-1", help="Import charset of dbf, maybe utf-8\ndefault iso-8859-1")
108112
@click.option('--dbfExportEncoding', 'dbfExportEncoding', default="iso-8859-1", help="Export charset of dbf, maybe utf-8\ndefault iso-8859-1")

src/canmatrix/convert.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,18 @@ def convert(infile, out_file_name, **options): # type: (str, str, **str) -> Non
307307
if signal.unit is "" and len(signal.values) == 0:
308308
logger.warning("Please add value table for the signal %s or add appropriate Unit", (frame.name+"::"+signal.name))
309309

310+
# Convert dbc from J1939 to Extended format
311+
if options.get('convertToExtended') is not None and options['convertToExtended']:
312+
for frame in db.frames:
313+
frame.is_j1939=False
314+
db.add_attribute("ProtocolType","ExtendedCAN")
315+
316+
# Convert dbc from Extended to J1939 format
317+
if options.get('convertToJ1939') is not None and options['convertToJ1939']:
318+
for frame in db.frames:
319+
frame.is_j1939=True
320+
db.add_attribute("ProtocolType","J1939")
321+
310322
logger.info(name)
311323
logger.info("%d Frames found" % (db.frames.__len__()))
312324

0 commit comments

Comments
 (0)