Merge pull request mi6#3053 from mi6/enable-row-highlighting-visual-t…

…ests Enable row highlighting visual tests
ec1467 · Jan 20, 2025 · 7d83b9b · 7d83b9b
2 parents 5ec6aff + 57ba643
commit 7d83b9b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/packages/canary-docs/docs.json b/packages/canary-docs/docs.json
@@ -1126,6 +1126,20 @@
           "docs": "Emitted when the `globalRowHeight` or `variableRowHeight` properties change in the data table.",
           "docsTags": []
         },
+        {
+          "event": "icSelectedRowChange",
+          "detail": "object",
+          "bubbles": true,
+          "complexType": {
+            "original": "object",
+            "resolved": "object",
+            "references": {}
+          },
+          "cancelable": true,
+          "composed": true,
+          "docs": "Emitted when the selected row changes in the data table.",
+          "docsTags": []
+        },
         {
           "event": "icSortChange",
           "detail": "IcSortEventDetail",

diff --git a/...f-screenshots/baseline/IcDataTable.cy.tsx-selected-row-highlight-turned-off.png b/...f-screenshots/baseline/IcDataTable.cy.tsx-selected-row-highlight-turned-off.png
diff --git a/...s-image-diff-screenshots/baseline/IcDataTable.cy.tsx-selected-row-highlight.png b/...s-image-diff-screenshots/baseline/IcDataTable.cy.tsx-selected-row-highlight.png
diff --git a/packages/canary-react/src/component-tests/IcDataTable/IcDataTable.cy.tsx b/packages/canary-react/src/component-tests/IcDataTable/IcDataTable.cy.tsx
@@ -4208,8 +4208,7 @@ describe("IcDataTable row selection", () => {
     cy.task("generateReport");
   });
 
-  // Test skipped due to issue creating snapshot image
-  it.skip("should highlight the selected row", () => {
+  it("should highlight the selected row", () => {
     mount(<BasicDataTable />);
 
     cy.checkHydrated(DATA_TABLE_SELECTOR);
@@ -4225,8 +4224,7 @@ describe("IcDataTable row selection", () => {
     });
   });
 
-  // Test skipped due to issue creating snapshot image
-  it.skip("should not highlight the selected row when the highlightSelectedRow prop is set to false", () => {
+  it("should not highlight the selected row when the highlightSelectedRow prop is set to false", () => {
     mount(<BasicDataTable highlightSelectedRow={false} />);
 
     cy.checkHydrated(DATA_TABLE_SELECTOR);