Skip to content

Commit f8fe374

Browse files
committed
minor fixes
1 parent 5a99c29 commit f8fe374

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

encoding/decode.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ func decodeValue(data []byte, out reflect.Value, ctx *Context, fl []flag, path E
226226
var dec Decoder
227227
if out.Type().Implements(decoderType) {
228228
dec = out.Interface().(Decoder)
229-
} else if reflect.PtrTo(out.Type()).Implements(decoderType) && out.CanAddr() {
229+
} else if reflect.PointerTo(out.Type()).Implements(decoderType) && out.CanAddr() {
230230
dec = out.Addr().Interface().(Decoder)
231231
}
232232
if dec != nil {
@@ -249,6 +249,7 @@ func decodeValue(data []byte, out reflect.Value, ctx *Context, fl []flag, path E
249249
Path: append(path, err.Path...),
250250
Err: err.Err,
251251
}
252+
return nil, err
252253
}
253254
if val.IsValid() {
254255
out.Set(val)

encoding/encode.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ func encodeValue(out io.Writer, val reflect.Value, ctx *Context, fl []flag, path
175175
// concrete type
176176
if val.Kind() != reflect.Interface {
177177
// user type
178-
if wantsVal := val.Type().Implements(encoderType); wantsVal || reflect.PtrTo(val.Type()).Implements(encoderType) && val.CanAddr() {
178+
if wantsVal := val.Type().Implements(encoderType); wantsVal || reflect.PointerTo(val.Type()).Implements(encoderType) && val.CanAddr() {
179179
var enc Encoder
180180
if wantsVal {
181181
enc = val.Interface().(Encoder)

0 commit comments

Comments
 (0)