-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
我可以提一个PR把esmodule模式改成cjs模式吗 #36
Comments
欢迎,但是工作量看起来有点大啊。 |
看了下还行,要改的不算多好像 |
这个感觉不用改也行,改了之后pr会一片红🤣 |
echo094
added a commit
that referenced
this issue
Sep 26, 2023
* refactor: convert esmodule to commonjs #36 Signed-off-by: cesaryuan <[email protected]> * lint Signed-off-by: echo094 <[email protected]> --------- Signed-off-by: echo094 <[email protected]> Co-authored-by: cesaryuan <[email protected]> Co-authored-by: echo094 <[email protected]>
我找到一个新的方案 nodejs/node#50430 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
es module的问题在于用vscode或者webstorm调试时不支持在uncaught exception处断下来,不利于调试(在尝试为decode-js做贡献,但是发现不支持异常断点调试起来好麻烦哈哈)
而cjs则没有这个问题,所以想问下大佬我可以提一个pr改成cjs模式嘛
The text was updated successfully, but these errors were encountered: