From 09135ed0d5dc946901a3c280dbe077e4a78a0f45 Mon Sep 17 00:00:00 2001 From: Chris <101201552+ChrisB-TL@users.noreply.github.com> Date: Thu, 23 Jan 2025 21:15:09 +0000 Subject: [PATCH] apply suggestions from review Co-authored-by: TJ Miller --- src/Concerns/ConfiguresProviders.php | 9 ++------- tests/Text/PendingRequestTest.php | 5 ++--- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/Concerns/ConfiguresProviders.php b/src/Concerns/ConfiguresProviders.php index 9922992b..febc8e6e 100644 --- a/src/Concerns/ConfiguresProviders.php +++ b/src/Concerns/ConfiguresProviders.php @@ -42,18 +42,13 @@ public function usingProviderConfig(array $config): self return $this; } - public function getModel(): string + public function model(): string { return $this->model; } - public function getProviderKey(): string + public function providerKey(): string { return $this->providerKey; } - - public function getProviderEnum(): ProviderEnum - { - return ProviderEnum::from($this->providerKey); - } } diff --git a/tests/Text/PendingRequestTest.php b/tests/Text/PendingRequestTest.php index 3bef33dd..7b76c2d9 100644 --- a/tests/Text/PendingRequestTest.php +++ b/tests/Text/PendingRequestTest.php @@ -43,9 +43,8 @@ $request = $this->pendingRequest ->using(Provider::OpenAI, 'gpt-4'); - expect($request->getModel())->toBe('gpt-4'); - expect($request->getProviderKey())->toBe('openai'); - expect($request->getProviderEnum())->toBe(Provider::OpenAI); + expect($request->model())->toBe('gpt-4'); + expect($request->providerKey())->toBe('openai'); }); test('it configures the client options', function (): void {